Closed Bug 1683809 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 26981 - Added a tab-size test (computed value)

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26981 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26981
Details from upstream follow.

b'G\xc3\xa9rard Talbot <github@gtalbot.org>' wrote:

Added a tab-size test (computed value)

/css/css-text/tab-size/tab-size-computed-value-001.html

This test spun from Issue 463

This test checks with an integer and with in, cm, mm, pt, pc, Q, px, em, ex, rem units: 11 sub-tests.

This test does NOT check with vw, vh, vmin, vmax and ch units.

For some strange+unexpected reason, Epiphany 3.32.1.2 (WebKitGTK+ 2.30.3) computes 2ex of typical Ahem font character as 31.9999 pixels ... I had to resort to use the assert_array_approx_equals function with a tolerance (epsilon) value.

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
FAIL: 11

Chrome

OK : 1
PASS: 11

Safari

OK : 1
PASS: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-text/tab-size/tab-size-computed-value-001.html
testing tab-size: 4: FAIL
testing tab-size: 0.5in: FAIL
testing tab-size: 2.54cm: FAIL
testing tab-size: 25.4mm: FAIL
testing tab-size: 18pt: FAIL
testing tab-size: 5pc: FAIL
testing tab-size: 101.6Q: FAIL
testing tab-size: 7px: FAIL
testing tab-size: 1em: FAIL
testing tab-size: 2ex: FAIL
testing tab-size: 3rem: FAIL

New Tests That Don't Pass

/css/css-text/tab-size/tab-size-computed-value-001.html
testing tab-size: 4: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 0.5in: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 2.54cm: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 25.4mm: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 18pt: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 5pc: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 101.6Q: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 7px: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 1em: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 2ex: FAIL (Chrome: PASS, Safari: PASS)
testing tab-size: 3rem: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e007bf003269
[wpt PR 26981] - Added a tab-size test (computed value), a=testonly
https://hg.mozilla.org/integration/autoland/rev/a5c94d55231a
[wpt PR 26981] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e007bf003269
https://hg.mozilla.org/mozilla-central/rev/a5c94d55231a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.