1683860 - Default search engine telemetry is not updated if the engine is modified

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Mark Banner (:standard8)]

If the details/parameters of the user's default search engine are changed whilst Firefox is running, then the telemetry environment is not updated.

Generally this shouldn't be an issue, however, if we did a live change of parameters on a search url, or if an add-on changed the parameters for a URL that we monitor, then we wouldn't see those reflected in the telemetry environment for that session.

The issue is that we currently only update the data when the environment is initialised, or when the default engine is changed.

https://searchfox.org/mozilla-central/rev/8698fade12984b9a6a43a85a287a5f17e8fd4ddf/toolkit/components/telemetry/app/TelemetryEnvironment.jsm#1376-1382

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1683860 - Update the search engine telemetry environment when the parameters of the default engine are changed. r?chutten!

Currently, the environment is only updated when the default engine is changed. Some configuration and url changes can cause the environment to be incorrect.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb9d8f5d8698
Update the search engine telemetry environment when the parameters of the default engine are changed. r=chutten

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/cb9d8f5d8698