1683863 - Investigate mitigated-by-backout reproducible crash on startup [@ mozilla::dom::quota::QuotaManager::InitializeOrigin ]

Status: RESOLVED WORKSFORME

(Core :: Storage: Quota Manager, defect, P3)

Description

[Tobias (:Tobbi) Markus]

Since updating to the latest nightly, my Firefox Nightly keeps crashing. Here is one of the crash reports:
https://crash-stats.mozilla.org/report/index/bc276359-909f-433c-810b-c45630201222#tab-details

about:support content is here: https://pastebin.com/j27BhFXZ

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Thanks for reporting that! I see there are such crashes from three installations so far.

Bug 1679540 promoted the overflow check, which is now at https://hg.mozilla.org/mozilla-central/annotate/54a95a4088a237cd14acc087cb433cb43216fbd1/dom/quota/ActorsParent.cpp#l5386, from a debug assertion to a diagnostic assertion, which is active in Nightly. Probably there was an overflow happening in the old code, but it just resulted in a wrong usage value immediately being passed to InitQuotaForOrigin. Maybe that resulted in a storage initialization error later on, but not a crash?

I'll request backout and provide a safer patch after the holidays.

:Tobbi, can you save your profile, and would you be willing to share it with us, so we can understand the root cause of this overflow?

Did you encounter any storage-related issues with that profile before the Nightly update?

Comment 3

[Tobias (:Tobbi) Markus]

I have several privacy-related concerns about sharing my profile, since this is my main Firefox profile and it contains a lot of sensitive data. Is there any way I can share the contents with you privately? The size of the compressed file is around 400 MB

I did not knowingly encounter any storage-related issues with that profile before.

Comment 4

[Simon Giesecke [:sg] [he/him]]

We understand your privacy concerns. We will check if there are other ways to better understand the root cause of the issue, but we will only be able to get back to this after the holidays.

The current Nightly should work again, as the patch that has likely caused the startup crash has been backed out.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Since the code causing the problem was backed out I'm repurposing this bug to track the investigation of the problem, but it could also make sense to close this in favor of tracking on the regressing bug.

Comment 6

[Simon Giesecke [:sg] [he/him]]

A modified patch now landed and this should no longer lead to a crash. However, I think you might have a storage initialization failure now. Could you check that and share the results of visiting https://firefox-storage-test.glitch.me/?

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1683863 - Log sources of negative usage values to browser console. r=#dom-workers-and-storage

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a6a31fa9985
Log sources of negative usage values to browser console. r=dom-workers-and-storage-reviewers,janv

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a6a31fa9985

Comment 10

[Simon Giesecke [:sg] [he/him]]

:tobbi, sorry I didn't wait for a response from you. I had another idea to mitigate the issue. I think that any storage initialization failure due to the underlying issue should now be resolved in the latest Nightly, but the corrupted storage directories probably still remain, and might render specific origins still unusable. Can you check your browser console for any QuotaManager warning?

Comment 11

[Tobias (:Tobbi) Markus]

I just restored my profile from the backup I made in December and updated to the latest nightly (I restored my Nightly due to other issues). There are no QuotaManager warnings in the browser console with the latest nightly and the contents of the backup profile.

Comment 12

[Simon Giesecke [:sg] [he/him]]

I won't get to this, unassigning and clearing NI.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Comment 14

[Jens Stutte [:jstutte]]

(In reply to Tobias (:Tobbi) Markus from comment #11)

I just restored my profile from the backup I made in December and updated to the latest nightly (I restored my Nightly due to other issues). There are no QuotaManager warnings in the browser console with the latest nightly and the contents of the backup profile.

Hi :tobbi, is there still something not working for you here? I assume you did not experience that crash anymore?

Comment 15

[Tobias (:Tobbi) Markus]

It doesn't look like this is an issue anymore. I haven't had any crash with that signature since the backout.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 17

[Jens Stutte [:jstutte]]

The very few remaining crashes seem unrelated to this investigation (the signature's function is quite big).