1684001 - Add blocklist to not use `deltaMode` attribute to `DOM_DELTA_MODE_PIXEL`

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Per domain? I have no concrete idea yet.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Do you have an example of how to best go about this? We've done similar things for window.event and such right?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Do you have an example of how to best go about this? We've done similar things for window.event and such right?

Right. I'm thinking about it's like: https://searchfox.org/mozilla-central/rev/44695ef057e422a8d6c6056972bdf32766c36187/layout/base/PresShell.cpp#8649-8653
But wheel event is fired too many times so, PresShell should store it, and set something a flag in WidgetWheelEvent.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684001 - IsURIInPrefList should be infallible. r=masayuki

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684001 - Move the code to compute a principal for blocklisting to Document. r=masayuki

Depends on D107455

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684001 - Add a pref-based blocklist to control default deltaMode. r=masayuki

Depends on D107456

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52c6a21b39fb
IsURIInPrefList should be infallible. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/2396dd65ee8d
Move the code to compute a principal for blocklisting to Document. r=masayuki

Comment 7

[Atila Butkovits]

Backed out for causing failures on test_ext_webRequest_filterResponseData.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e682f4655ac9267ee397f4f6bcda4be3c5696b43

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OHfp-XZyTqSrp6JBjGQvEQ.0&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-linux1804-64%2Fdebug-xpcshell-e10s%2Cx5&revision=2396dd65ee8df418fbee3e6be4ad9d4fef421770

Failure log: https://treeherder.mozilla.org/logviewer?job_id=332471300&repo=autoland&lineNumber=2588

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feb05154b415
IsURIInPrefList should be infallible. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/92cfd047b6ca
Move the code to compute a principal for blocklisting to Document. r=masayuki

Comment 9

[Emilio Cobos Álvarez (:emilio)]

As per Matrix discussion I don't think this is related to my push.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22e1a448b65d
Add a pref-based blocklist to control default deltaMode. r=masayuki

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc1937c866de
Fix bustage.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/feb05154b415
https://hg.mozilla.org/mozilla-central/rev/92cfd047b6ca
https://hg.mozilla.org/mozilla-central/rev/22e1a448b65d
https://hg.mozilla.org/mozilla-central/rev/cc1937c866de