Closed Bug 1684082 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27002 - Re-write wpt/cookies/http-state/ path tests

Categories

(Core :: Networking: Cookies, task, P4)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27002 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27002
Details from upstream follow.

b'Mike Taylor <miketaylr@chromium.org>' wrote:

Re-write wpt/cookies/http-state/ path tests

This also adds support for sending multiple Set-Cookie strings
to the test infrastructure.

Notes for history books (and reviewers)
legacy test => ported test cookie name map
path0001 => (path.html) testA=11...
path0002 => (path.html) testB=12...
path0003 => (path.html) testA=13...
path0004 => (path.html) testB=14...
path0005 => (path.html) test=15
path0006 => (path.html) test=16
path0007 => (path-redirect.html) test=1
path0008 => (path-redirect.html) test=9
path0009 => (path-redirect.html) test=10
path0010 => (path-redirect.html) test=2
path0011 => (path-redirect.html) test=11
path0012 => (path-redirect.html) test=12
path0013 => (path-redirect.html) test=13
path0014 => (path-redirect.html) test=17
path0015 => not ported, see note below.
path0016 => (path-redirect.html) test=3
path0017 => (path-redirect.html) test=4
path0018 => (path-redirect.html) test=14
path0019, dupe of (path.html) test1, not ported
path0020, dupe of (path.html) test2, not ported
path0021, dupe of (path.html) test3, not ported
path0022 => (path.html) test=17
path0023 => (path.html) test=18
path0024 => (path-redirect.html) test=15
path0025 => (path-redirect.html) test=16
path0026 => (path-redirect.html) test=5
path0027 => (path-redirect.html) test=6
path0028 => (path-redirect.html) test=7a
disabled-path0029 (path-redirect.html) test=7b
path0029 => (path.html) test=19
path0030, dupe of (path.html) test8, not ported
path0031 => path.html test=20
path0032 => (path-redirect.html) testA=8; testB=8

Notes:
For path0027 and path0028, I'm swapping the assertions (to expected a cookie) because Firefox, Safari and Chrome do this.

path0015 isn't possible to port with current WPT infra (as there are no dynamic handlers, and '/' is treated as a directory "mount").
https://bugs.chromium.org/p/chromium/issues/detail?id=1161544 is filed to track that work.

Bug: 1159925
Change-Id: I37da066e60d79e3f99e01a7d6ccbc408f447e01b
Reviewed-on: https://chromium-review.googlesource.com/2598139
WPT-Export-Revision: f46fa553ccf361518a1e9e485187ab310944739b

Component: web-platform-tests → Networking: Cookies
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 2 subtests

Status Summary

Firefox

OK : 10
PASS: 84
FAIL: 2

Chrome

OK : 10
PASS: 86

Safari

OK : 10
PASS: 74
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/cookies/attributes/path-redirect.html
No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL
No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL

New Tests That Don't Pass

/cookies/attributes/path-redirect.html
No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL (Chrome: PASS, Safari: PASS)
No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e10e60103c9f [wpt PR 27002] - Re-write wpt/cookies/http-state/ path tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/53bda6b5aa13 [wpt PR 27002] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e10e60103c9f
https://hg.mozilla.org/mozilla-central/rev/53bda6b5aa13

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.