1684412 - Graphics errors in about:support, Present1 failed: 0x887a0001

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Trevor Rowbotham [:rowbot]]

Attachment: about:support

I have been seeing some graphics errors logged to about:support recently. Unfortunately, I don't have any concrete STR. I do have the webrender compositor disabled due to bug 1638709, which could be related. I'll try to find a way to reproduce this.

A google search turned up 2 results (post 1, post 2) for similar "Present1 failed" messages, which seem to indicate that this first became an issue in Fx 83, and a reddit comment with a similar error on Intel Sandy Bridge igpus going back to Fx 77.

Failure Log
(#0) GP+[GFX1-]: Present1 failed: 0x887a0001
(#1) GP+[GFX1-]: Present1 failed: 0x887a0001
(#2) GP+[GFX1-]: Present1 failed: 0x887a0001

Comment 1

[Jim Mathies [:jimm]]

DXGI_ERROR_INVALID_CALL
0x887A0001 - The application provided invalid parameter data; this must be debugged and fixed before the application is released.

Comment 2

[Sotaro Ikeda [:sotaro]]

SwapChain is used only when native compositor is disabled on Win10.

Comment 3

[Trevor Rowbotham [:rowbot]]

These STR still aren't great, but its the closest I've come to finding something that reproduces somewhat reliably:

1. Set gfx.webrender.compositor to false and restart the browser. (Not 100% sure this is necessary)
2. Go to https://www.imdb.com/title/tt2560140/
3. At the top of the page, hopefully, there should be a large yellow banner that says "Get a sneak peek of the new version of this page."; click on the "Check it out now" link in the banner.
4. Scrolling up and down and mousing over stuff seems to trigger the GP+[GFX1-]: Present1 failed: 0x887a0001 errors relatively frequently for me. Refreshing the page and repeating this step may help in reproducing.

I'm using the latest Nightly, with an nvidia RTX 2080, driver version 469.01. Please let me know if you need any additional information.

Comment 4

[Sotaro Ikeda [:sotaro]]

I could reproduce the problem. I am going to look into it.

Comment 5

[Sotaro Ikeda [:sotaro]]

"Present1 failed" happened for me when dirty rect was empty.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1684412 - Pass only valid rests to Present1()

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72b2aeaa5800
Pass only valid rests to Present1() r=nical

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72b2aeaa5800

Comment 9

[Rares Doghi, Desktop QA]

Hi, I tried to reproduce the issue based on the steps from Comment 3 on a Desktop Machine with Nvidia GT 730 as well as a Dell Laptop with Nvidia GeForce GTX 1650, but the issue does not occur on our end and we cannot confirm this Fix, Trevor can you please try to reproduce this issue in our latest Beta build and let us know if it no longer occurs on your end as well ? I think this issue might be related to the RTX 2080 gpu.

I will leave the link for the Beta build here : https://www.mozilla.org/en-US/firefox/channel/desktop/

Comment 10

[Trevor Rowbotham [:rowbot]]

I no longer get this error after this patch, thanks.

Comment 11

[Rares Doghi, Desktop QA]

Thank you for checking, I will update the qe-verify and tracking flags.