The Personalize button's clicked and hover states are reversed
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | unaffected |
firefox85 | --- | verified |
firefox86 | --- | verified |
People
(Reporter: cmuresan, Assigned: ewright)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
[Affected versions]:
- Firefox Nightly 86.0a1, BuildID 20201228205313
- Firefox Beta 85.0b4, BuildID 20201220193140
[Affected Platforms]:
- Windows 10
- macOS 10.15
- Linux MX 4.19
[Prerequisites]:
- Have a new Firefox profile.
- Have the
browser.newtabpage.activity-stream.newNewtabExperience.enabled
pref set totrue
.
[Steps to reproduce]:
- Open the browser with the profile from prerequisites and open a new tab.
- Hover the "Personalize" button and observe the bahavior.
- Click and hold the "Personalize" button and observe the behavior.
[Expected results]:
- Light theme:
- Step 2: The button has a dark gray hover effect.
- Step 3: The button becomes darker.
- Dark theme:
- Step 2: The button has a light gray hover effect.
- Step 3: The button becomes even lighter.
[Actual results]:
- Light theme:
- Step 2: The button has a dark gray hover effect.
- Step 3: The button becomes lighter.
- Dark theme:
- Step 2: The button has a light gray hover effect.
- Step 3: The button becomes darker.
[Additional notes]:
- The issue is also reproducible on the Light theme, but it's much more noticeable on Dark theme.
- Attached a screen recording of the issue.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 3•4 years ago
|
||
bugherder |
Comment 4•4 years ago
|
||
The patch landed in nightly and beta is affected.
:ewright, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9195865 [details]
Bug 1684459 - Hover and active states are no longer reversed.
Beta/Release Uplift Approval Request
- User impact if declined: Hover states are reversed, it could seem unprofessional. This will only be seen by users in an experiment.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): small CSS only patch. Will only be seen by users enrolled in an experiment.
- String changes made/needed: none
Comment 6•4 years ago
|
||
Comment on attachment 9195865 [details]
Bug 1684459 - Hover and active states are no longer reversed.
approved for 85.0b8
Comment 7•4 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 8•4 years ago
|
||
I have verified that the issue is no longer reproducible on the latest Firefox Nightly (86.0a1, BuildID 20210113043149) and the latest Firefox Beta (85.0b8, Build ID 20210112185508) using Windows 10, macOS 10.15.7, and Linux MX 4.19.
Description
•