Closed
Bug 1684463
Opened 3 years ago
Closed 3 years ago
Refactor element-editor#_createAttribute function
Categories
(DevTools :: Inspector, task, P3)
DevTools
Inspector
Tracking
(firefox86 fixed)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
The element-editor#_createAttribute is rather long and one easy thing we can do to shorten it is to move the collapse function out into its own private function and add some better JSDoc to make it clearer what _createAttribute is doing.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9194878 -
Attachment description: Bug 1684463 - Shorten the _createAttribute function by refactoring the collapse function. r=jdescottes → Bug 1684463 - [devtools] Shorten the _createAttribute function by refactoring the collapse function. r=jdescottes
|
|
Assignee | |
Updated•3 years ago
|
Summary: Shorten the _createAttribute function by refactoring the collapse function → Refactor element-editor#_createAttribute function
|
|
||
Updated•3 years ago
|
Attachment #9194878 -
Attachment description: Bug 1684463 - [devtools] Shorten the _createAttribute function by refactoring the collapse function. r=jdescottes → Bug 1684463 - [devtools] Part 1: Shorten the _createAttribute function by refactoring the collapse function. r=jdescottes
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D100525
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D100527
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e99066681c26 [devtools] Part 1: Shorten the _createAttribute function by refactoring the collapse function. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/84b177d10c21 [devtools] Part 2: Split the appending attribute value logic out into _appendAttributeValue. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/64d04865c55c [devtools] Part 3: Split making the attribute editable logic out into _setupAttributeEditor. r=jdescottes
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e99066681c26
https://hg.mozilla.org/mozilla-central/rev/84b177d10c21
https://hg.mozilla.org/mozilla-central/rev/64d04865c55c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•