168448 - PSM embedding freeze/ step 1/ move stuff & change data types

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert [:KaiE:]]

We are in the process of freezing several interfaces required by embeddors.
It turns out that a lot of cleanup is needed in PSM.

With this bug I would like to do a first step, and only do the following:
- move interfaces to separate IDL files
- move some implementation code to separate files
- remove functionality that is currently exposed,
  but not required by embeddors, and not ready for getting frozen
- change some data types used in interfaces
- split some interfaces into separate interfaces

And of course, the most important thing is, after doing all the above changes,
make sure the code still compiles and actually works :-)

I want to care for adding documentation in a separate patch (and bug).

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch / 14100 lines!

This patch is the full change.

It is rather difficult to review, since A LOT of the code is actually moving
stuff around. This patch has 14000 lines, and around 10000 lines have to do
with moving.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: special patch / ignoring all moves / for easier reviewing / "only" 4700 lines

This is not really a patch, it's rather a helpful diff.

It took me a lot of work to create this version of the patch.
I created it by reverting all the moves (that are done in the first patch) in
order to create a diff that only lists what is really getting changed.

Comment 3

[Kai Engert [:KaiE:]]

Javi, Alec,

I would like to ask you to review this patch today, if at all possibl, because I
would like to land this weekend.

This patch is so large, that it rather blocks anything else I could work on.

If you have change requests, I would like to ask you to give me your review
stamp anyway, in order to allow me to get rid of this large patch from my tree.
I promise to immediately work on all change requests you have before working on
anything else.

Thanks.

Comment 4

[Javier Delgadillo]

Comment on attachment 99044 [details] [diff] [review]
special patch / ignoring all moves / for easier reviewing / "only" 4700 lines

Update comment for consistenecy:

 /* void viewCert (in nsIX509Cert cert); */
 NS_IMETHODIMP 
-nsNSSDialogs::ViewCert(nsIX509Cert *cert)
+nsNSSDialogs::ViewCert(nsIInterfaceRequestor *ctx, 
+			nsIX509Cert *cert)

Everything seems OK.
r=javi

Comment 5

[Alec Flett]

Comment on attachment 99044 [details] [diff] [review]
special patch / ignoring all moves / for easier reviewing / "only" 4700 lines

argh! I keep trying to review this but I keep losing my changes in the "Edit
Attachment As Comment" window, so I'll try to add comments here:

- use QueryElementAt(i, nsIFoo) rather than
GetElementAt(i).QueryInterface(nsIFoo)
- don't use NSPR types in IDL unless you're referring to a bitfield
- when you have "out" arrays, you should make the array be the last parameter,
and use [retval] so that the scripter can say foo=bar.getRawDER(length);
- w/computeNextAutoUpdateTime, what did we decide, I can't remember? if the
method is going away, its fine as it is, but if the method is sticking around
then it should be returning an PRTime and let the consumer reformat it. Also,
why do we need a "double" for noOfDays? Can that just be a relative PRTime
instead? Or a "long" if we just need an integral value? Also, why does it now
take an nsICRLInfo, when its inside the nsICRLInfo interface as it is?
- Not sure what's happening to nsIPK11Token, becoming nsISupports in  - what is
the embeddor supposed to pass here? do they get the object from somewhere else?
- I'm assuming the "actually moved to c++ header" comes from another part of
this patch, and its just for reference now?
- in nsCMS.cpp, please use do_QueryElementAt() - it makes it more obvious if
you're leaking or not. Also, why do you need to do these multiple casts to get
to the nsNSSCertificate?, and then call GetCert() - this seems like a scary
cast since you're casting from an interface to a concrete object. Can you add
some comments in the code explaining why this is safe?
- in nsNSSCertificate.cpp why are you casting "this" to nsIX509Cert? At the
very least you should just be doing a direct assignment instead of going
through do_QueryInterface.

Sorry, I know this is big, but if these issues are addressed, then an sr= will
come quickly :)

Comment 6

[Kai Engert [:KaiE:]]

> - use QueryElementAt(i, nsIFoo) rather than
> GetElementAt(i).QueryInterface(nsIFoo)

Ok, I will.


> - don't use NSPR types in IDL unless you're referring to a bitfield

Which particular types are you refering to?


> - when you have "out" arrays, you should make the array be the last parameter,
> and use [retval] so that the scripter can say foo=bar.getRawDER(length);

getRawDER is the only place where I have an out array.
I will change it.


> - w/computeNextAutoUpdateTime, what did we decide, I can't remember? if the
> method is going away, its fine as it is, but if the method is sticking around
> then it should be returning an PRTime and let the consumer reformat it. Also,
> why do we need a "double" for noOfDays? Can that just be a relative PRTime
> instead? Or a "long" if we just need an integral value? Also, why does it now
> take an nsICRLInfo, when its inside the nsICRLInfo interface as it is?

We decided to move that function to a separate interface.
The patch moves that function to new interface NSICRLManager.

I did not write that function compute...
At the current time, I would like to concentrate on preparing the interface
freeze by only moving code, and not introduce further risks by changing code I
haven't understood yet.
That function is being moved to nsICRLManager, which is not on the candiate list
for getting frozen.

That function is not in the nsICRLInfo function any more. Please look at the
large patch. It is in nsICRLManager.
That "special patch" is really mostly showing only the changes, while the
context is not correct there.
It was the only way I could think of to give us a chance to see all the changes,
without getting confused by all the moves.


> - Not sure what's happening to nsIPK11Token, becoming nsISupports in  - what is
> the embeddor supposed to pass here? do they get the object from somewhere else?

It is allowed to pass in NULL for all token parameters.
I'll mention that in the comments.
The current embeddors I know of are all passing in NULL.
We are changing that parameter to nsISupports, because we don't want to freeze
nsIPK11Token now.

In the future, if embeddors actually do care about what device (token) to deal
with, they are free to do it.


> - I'm assuming the "actually moved to c++ header" comes from another part of
> this patch, and its just for reference now?

I begin to wonder whether my "special patch" is more confusing than helpful.
That comment is not contained in the real patch, it is only in the special patch.
I should have labeled it [note to reviewer] possibly.
It is just showing the former interface function has been turned into a C++
header, now being contained in a C++ header.


> - in nsCMS.cpp, please use do_QueryElementAt() - it makes it more obvious if
> you're leaking or not. Also, why do you need to do these multiple casts to get
> to the nsNSSCertificate?, and then call GetCert() - this seems like a scary
> cast since you're casting from an interface to a concrete object. Can you add
> some comments in the code explaining why this is safe?

That scary cast has been added in the past by someone else.
In fact, that code seems to assume that the only implementation of nsIX509Cert
will be the concrete class nsNSSCertificate.
With the patch I have changed class nsNSSCertificate to be now inherited from
multiple interfaces.
I received a "ambiguity" compiler error, when I tried to cast directly to the
concrete class.
Because of the multiple inheritance, the path from nsISupports to nsNSSSupports
is now ambigous.
By casting to nsIX509Cert first, the compiler knows which path we're refering to
and can possibly cast to the concrete object without ambiguity.
I will add the comment.


> - in nsNSSCertificate.cpp why are you casting "this" to nsIX509Cert? At the
> very least you should just be doing a direct assignment instead of going
> through do_QueryInterface.

Same as before, because of the now introduced ambiguity because of the multiple
inheritance.
I did not yet look into the reason why that indirection going over
QueryInterface and nsCOMPtr was used, I was only making it compile again,
staying in the existing code as much as possible.
The context at that particular location is small. If it were larger, you'd see
the next step in that function is calling GetProxyForObject.
I don't know the internals of the proxy functions good enough to say whether the
input to that function must actually be a nsCOMPtr, or whether a plain pointer
is good enough - which might actually be enough, because the interface ID is
passed over as well. I can check whether we can just get rid of the
QueryInterface step.

Comment 7

[Alec Flett]

ah, ok, I see how some of these things line up with respect to the giant patch
vs. the small patch then. As for NSPR types, I saw a few "PRUint32" when you
should have had "unsigned long" and so forth. You can just grep through the IDL
that you're changing and you'll see what I mean:

grep Index: foo.patch | cut -b8- | xargs grep PRUint32

and so forth.

So my only issue now is with the casting stuff.. but it is actually easy to fix.
when you need to do an abiguous cast, you just cast to a higher level first, but
make sure to use NS_STATIC_CAST

for instance
nsCOMPtr<nsIX509Cert> cert = NS_STATIC_CAST(nsIX509Cert*,
NS_STATIC_CAST(nsISupports*,this));

(or maybe I have that backwards? You'll have to play with the compiler a bit..)

basically raw "old style" casts (like "(nsIX509Cert*)this") are considered bad,
because they don't do enough type checking during compile time. NS_STATIC_CAST
will make sure to do the right type checking.

but in any case, what I was saying about do_QueryInterface is that it doesn't
make sense to say do_QueryInterface(this) because "this" is already
NS_STATIC_CAST'able to any interface that it implements. You don't need
QueryInterface at all.

Comment 8

[Kai Engert [:KaiE:]]

> - use QueryElementAt(i, nsIFoo) rather than
> GetElementAt(i).QueryInterface(nsIFoo)

done


> - when you have "out" arrays, you should make the array be the last parameter,
> and use [retval] so that the scripter can say foo=bar.getRawDER(length);

done


> So my only issue now is with the casting stuff.. but it is actually easy to fix.
> when you need to do an abiguous cast, you just cast to a higher level first, but
> make sure to use NS_STATIC_CAST

done

Now using:
+    nssRecipientCert = 
+      NS_STATIC_CAST(nsNSSCertificate*, 
+                     NS_STATIC_CAST(nsIX509Cert*, x509cert));

and replaced
  do_QueryInterface((nsIX509Cert*)this);
with
  NS_STATIC_CAST(nsIX509Cert*, this)

Comment 9

[Kai Engert [:KaiE:]]

Attachment: Patch v2

Comment 10

[Kai Engert [:KaiE:]]

Note: I did not create new logic, but only moved stuff to separate files.
Therefore, I did not create new license headers. When I created new files as a
destination for existing code, I copied the license header from the original
source file.

Comment 11

[Alec Flett]

Comment on attachment 99347 [details] [diff] [review]
Patch v2

sr=alecf

Comment 12

[Kai Engert [:KaiE:]]

Comment on attachment 99347 [details] [diff] [review]
Patch v2

carrying forward r=javi from comment 4

Comment 13

[Kai Engert [:KaiE:]]

Checked in to trunk:

Checking in security/manager/boot/public/nsISecurityWarningDialogs.idl;
/cvsroot/mozilla/security/manager/boot/public/nsISecurityWarningDialogs.idl,v 
<--  nsISecurityWarningDialogs.idl
new revision: 1.2; previous revision: 1.1
done
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in security/manager/pki/macbuild/PIPPKI.xml;
/cvsroot/mozilla/security/manager/pki/macbuild/PIPPKI.xml,v  <--  PIPPKI.xml
new revision: 1.4; previous revision: 1.3
done
Checking in security/manager/pki/resources/content/PageInfoOverlay.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/PageInfoOverlay.xul,v 
<--  PageInfoOverlay.xul
new revision: 1.17; previous revision: 1.16
done
Checking in security/manager/pki/resources/content/certManager.js;
/cvsroot/mozilla/security/manager/pki/resources/content/certManager.js,v  <-- 
certManager.js
new revision: 1.39; previous revision: 1.38
done
Checking in security/manager/pki/resources/content/certManager.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/certManager.xul,v  <-- 
certManager.xul
new revision: 1.23; previous revision: 1.22
done
Checking in security/manager/pki/resources/content/crlImportDialog.js;
/cvsroot/mozilla/security/manager/pki/resources/content/crlImportDialog.js,v 
<--  crlImportDialog.js
new revision: 1.6; previous revision: 1.5
done
Checking in security/manager/pki/resources/content/crlManager.js;
/cvsroot/mozilla/security/manager/pki/resources/content/crlManager.js,v  <-- 
crlManager.js
new revision: 1.7; previous revision: 1.6
done
Checking in security/manager/pki/resources/content/domainMismatch.js;
/cvsroot/mozilla/security/manager/pki/resources/content/domainMismatch.js,v  <--
 domainMismatch.js
new revision: 1.12; previous revision: 1.11
done
Checking in security/manager/pki/resources/content/downloadcert.js;
/cvsroot/mozilla/security/manager/pki/resources/content/downloadcert.js,v  <-- 
downloadcert.js
new revision: 1.9; previous revision: 1.8
done
Checking in security/manager/pki/resources/content/escrowWarn.js;
/cvsroot/mozilla/security/manager/pki/resources/content/escrowWarn.js,v  <-- 
escrowWarn.js
new revision: 1.6; previous revision: 1.5
done
Checking in security/manager/pki/resources/content/newserver.js;
/cvsroot/mozilla/security/manager/pki/resources/content/newserver.js,v  <-- 
newserver.js
new revision: 1.17; previous revision: 1.16
done
Checking in security/manager/pki/resources/content/pippki.js;
/cvsroot/mozilla/security/manager/pki/resources/content/pippki.js,v  <--  pippki.js
new revision: 1.2; previous revision: 1.1
done
Checking in security/manager/pki/resources/content/pref-crlupdate.js;
/cvsroot/mozilla/security/manager/pki/resources/content/pref-crlupdate.js,v  <--
 pref-crlupdate.js
new revision: 1.5; previous revision: 1.4
done
Checking in security/manager/pki/resources/content/serverCertExpired.js;
/cvsroot/mozilla/security/manager/pki/resources/content/serverCertExpired.js,v 
<--  serverCertExpired.js
new revision: 1.12; previous revision: 1.11
done
Checking in security/manager/pki/src/Makefile.in;
/cvsroot/mozilla/security/manager/pki/src/Makefile.in,v  <--  Makefile.in
new revision: 1.19; previous revision: 1.18
done
Checking in security/manager/pki/src/nsASN1Tree.h;
/cvsroot/mozilla/security/manager/pki/src/nsASN1Tree.h,v  <--  nsASN1Tree.h
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/security/manager/pki/src/nsNSSDialogHelper.cpp,v
done
Checking in security/manager/pki/src/nsNSSDialogHelper.cpp;
/cvsroot/mozilla/security/manager/pki/src/nsNSSDialogHelper.cpp,v  <-- 
nsNSSDialogHelper.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/pki/src/nsNSSDialogHelper.h,v
done
Checking in security/manager/pki/src/nsNSSDialogHelper.h;
/cvsroot/mozilla/security/manager/pki/src/nsNSSDialogHelper.h,v  <-- 
nsNSSDialogHelper.h
initial revision: 1.1
done
Checking in security/manager/pki/src/nsNSSDialogs.cpp;
/cvsroot/mozilla/security/manager/pki/src/nsNSSDialogs.cpp,v  <--  nsNSSDialogs.cpp
new revision: 1.52; previous revision: 1.51
done
Checking in security/manager/pki/src/nsNSSDialogs.h;
/cvsroot/mozilla/security/manager/pki/src/nsNSSDialogs.h,v  <--  nsNSSDialogs.h
new revision: 1.13; previous revision: 1.12
done
Checking in security/manager/pki/src/nsPKIModule.cpp;
/cvsroot/mozilla/security/manager/pki/src/nsPKIModule.cpp,v  <--  nsPKIModule.cpp
new revision: 1.10; previous revision: 1.9
done
Checking in security/manager/ssl/macbuild/PIPNSS.xml;
/cvsroot/mozilla/security/manager/ssl/macbuild/PIPNSS.xml,v  <--  PIPNSS.xml
new revision: 1.7; previous revision: 1.6
done
Checking in security/manager/ssl/macbuild/pipnssIDL.xml;
/cvsroot/mozilla/security/manager/ssl/macbuild/pipnssIDL.xml,v  <--  pipnssIDL.xml
new revision: 1.6; previous revision: 1.5
done
Checking in security/manager/ssl/public/Makefile.in;
/cvsroot/mozilla/security/manager/ssl/public/Makefile.in,v  <--  Makefile.in
new revision: 1.13; previous revision: 1.12
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIASN1Object.idl,v
done
Checking in security/manager/ssl/public/nsIASN1Object.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIASN1Object.idl,v  <-- 
nsIASN1Object.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIASN1PrintableItem.idl,v
done
Checking in security/manager/ssl/public/nsIASN1PrintableItem.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIASN1PrintableItem.idl,v  <-- 
nsIASN1PrintableItem.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIASN1Sequence.idl,v
done
Checking in security/manager/ssl/public/nsIASN1Sequence.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIASN1Sequence.idl,v  <-- 
nsIASN1Sequence.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsIBadCertListener.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIBadCertListener.idl,v  <-- 
nsIBadCertListener.idl
new revision: 1.8; previous revision: 1.7
done
Removing security/manager/ssl/public/nsICMS.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMS.idl,v  <--  nsICMS.idl
new revision: delete; previous revision: 1.5
done
Checking in security/manager/ssl/public/nsICMSDecoder.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMSDecoder.idl,v  <-- 
nsICMSDecoder.idl
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICMSEncoder.idl,v
done
Checking in security/manager/ssl/public/nsICMSEncoder.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMSEncoder.idl,v  <-- 
nsICMSEncoder.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsICMSMessage.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMSMessage.idl,v  <-- 
nsICMSMessage.idl
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICMSMessageErrors.idl,v
done
Checking in security/manager/ssl/public/nsICMSMessageErrors.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMSMessageErrors.idl,v  <-- 
nsICMSMessageErrors.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsICMSSecureMessage.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICMSSecureMessage.idl,v  <-- 
nsICMSSecureMessage.idl
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICRLInfo.idl,v
done
Checking in security/manager/ssl/public/nsICRLInfo.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICRLInfo.idl,v  <--  nsICRLInfo.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICRLManager.idl,v
done
Checking in security/manager/ssl/public/nsICRLManager.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICRLManager.idl,v  <-- 
nsICRLManager.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICertPickDialogs.idl,v
done
Checking in security/manager/ssl/public/nsICertPickDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICertPickDialogs.idl,v  <-- 
nsICertPickDialogs.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsICertTree.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICertTree.idl,v  <--  nsICertTree.idl
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsICertificateDialogs.idl,v
done
Checking in security/manager/ssl/public/nsICertificateDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsICertificateDialogs.idl,v  <-- 
nsICertificateDialogs.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIClientAuthDialogs.idl,v
done
Checking in security/manager/ssl/public/nsIClientAuthDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIClientAuthDialogs.idl,v  <-- 
nsIClientAuthDialogs.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIDOMCryptoDialogs.idl,v
done
Checking in security/manager/ssl/public/nsIDOMCryptoDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIDOMCryptoDialogs.idl,v  <-- 
nsIDOMCryptoDialogs.idl
initial revision: 1.1
done
RCS file:
/cvsroot/mozilla/security/manager/ssl/public/nsIGeneratingKeypairInfoDialogs.idl,v
done
Checking in security/manager/ssl/public/nsIGeneratingKeypairInfoDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIGeneratingKeypairInfoDialogs.idl,v
 <--  nsIGeneratingKeypairInfoDialogs.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIHash.idl,v
done
Checking in security/manager/ssl/public/nsIHash.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIHash.idl,v  <--  nsIHash.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsIKeygenThread.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIKeygenThread.idl,v  <-- 
nsIKeygenThread.idl
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsINSSCertCache.idl,v
done
Checking in security/manager/ssl/public/nsINSSCertCache.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsINSSCertCache.idl,v  <-- 
nsINSSCertCache.idl
initial revision: 1.1
done
Removing security/manager/ssl/public/nsINSSDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsINSSDialogs.idl,v  <-- 
nsINSSDialogs.idl
new revision: delete; previous revision: 1.18
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIOCSPResponder.idl,v
done
Checking in security/manager/ssl/public/nsIOCSPResponder.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIOCSPResponder.idl,v  <-- 
nsIOCSPResponder.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIPK11Token.idl,v
done
Checking in security/manager/ssl/public/nsIPK11Token.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIPK11Token.idl,v  <-- 
nsIPK11Token.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsIPK11TokenDB.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIPK11TokenDB.idl,v  <-- 
nsIPK11TokenDB.idl
new revision: 1.8; previous revision: 1.7
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIPKCS11Module.idl,v
done
Checking in security/manager/ssl/public/nsIPKCS11Module.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIPKCS11Module.idl,v  <-- 
nsIPKCS11Module.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIPKCS11ModuleDB.idl,v
done
Checking in security/manager/ssl/public/nsIPKCS11ModuleDB.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIPKCS11ModuleDB.idl,v  <-- 
nsIPKCS11ModuleDB.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsIPKCS11Slot.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIPKCS11Slot.idl,v  <-- 
nsIPKCS11Slot.idl
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsISMimeCert.idl,v
done
Checking in security/manager/ssl/public/nsISMimeCert.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsISMimeCert.idl,v  <-- 
nsISMimeCert.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsITokenDialogs.idl,v
done
Checking in security/manager/ssl/public/nsITokenDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsITokenDialogs.idl,v  <-- 
nsITokenDialogs.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsITokenPasswordDialogs.idl,v
done
Checking in security/manager/ssl/public/nsITokenPasswordDialogs.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsITokenPasswordDialogs.idl,v  <--
 nsITokenPasswordDialogs.idl
initial revision: 1.1
done
Checking in security/manager/ssl/public/nsIX509Cert.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIX509Cert.idl,v  <--  nsIX509Cert.idl
new revision: 1.24; previous revision: 1.23
done
Checking in security/manager/ssl/public/nsIX509CertDB.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIX509CertDB.idl,v  <-- 
nsIX509CertDB.idl
new revision: 1.23; previous revision: 1.22
done
RCS file: /cvsroot/mozilla/security/manager/ssl/public/nsIX509CertValidity.idl,v
done
Checking in security/manager/ssl/public/nsIX509CertValidity.idl;
/cvsroot/mozilla/security/manager/ssl/public/nsIX509CertValidity.idl,v  <-- 
nsIX509CertValidity.idl
initial revision: 1.1
done
Checking in security/manager/ssl/src/Makefile.in;
/cvsroot/mozilla/security/manager/ssl/src/Makefile.in,v  <--  Makefile.in
new revision: 1.48; previous revision: 1.47
done
Checking in security/manager/ssl/src/nsCMS.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCMS.cpp,v  <--  nsCMS.cpp
new revision: 1.9; previous revision: 1.8
done
Checking in security/manager/ssl/src/nsCMS.h;
/cvsroot/mozilla/security/manager/ssl/src/nsCMS.h,v  <--  nsCMS.h
new revision: 1.5; previous revision: 1.4
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsCRLInfo.cpp,v
done
Checking in security/manager/ssl/src/nsCRLInfo.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCRLInfo.cpp,v  <--  nsCRLInfo.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsCRLInfo.h,v
done
Checking in security/manager/ssl/src/nsCRLInfo.h;
/cvsroot/mozilla/security/manager/ssl/src/nsCRLInfo.h,v  <--  nsCRLInfo.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsCRLManager.cpp,v
done
Checking in security/manager/ssl/src/nsCRLManager.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCRLManager.cpp,v  <--  nsCRLManager.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsCRLManager.h,v
done
Checking in security/manager/ssl/src/nsCRLManager.h;
/cvsroot/mozilla/security/manager/ssl/src/nsCRLManager.h,v  <--  nsCRLManager.h
initial revision: 1.1
done
Checking in security/manager/ssl/src/nsCertPicker.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCertPicker.cpp,v  <--  nsCertPicker.cpp
new revision: 1.6; previous revision: 1.5
done
Checking in security/manager/ssl/src/nsCertTree.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCertTree.cpp,v  <--  nsCertTree.cpp
new revision: 1.27; previous revision: 1.26
done
Checking in security/manager/ssl/src/nsCertTree.h;
/cvsroot/mozilla/security/manager/ssl/src/nsCertTree.h,v  <--  nsCertTree.h
new revision: 1.8; previous revision: 1.7
done
Checking in security/manager/ssl/src/nsCrypto.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCrypto.cpp,v  <--  nsCrypto.cpp
new revision: 1.24; previous revision: 1.23
done
Checking in security/manager/ssl/src/nsKeygenHandler.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsKeygenHandler.cpp,v  <-- 
nsKeygenHandler.cpp
new revision: 1.19; previous revision: 1.18
done
Checking in security/manager/ssl/src/nsKeygenThread.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsKeygenThread.cpp,v  <-- 
nsKeygenThread.cpp
new revision: 1.6; previous revision: 1.5
done
Checking in security/manager/ssl/src/nsNSSASN1Object.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSASN1Object.h,v  <-- 
nsNSSASN1Object.h
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertCache.cpp,v
done
Checking in security/manager/ssl/src/nsNSSCertCache.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertCache.cpp,v  <-- 
nsNSSCertCache.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertCache.h,v
done
Checking in security/manager/ssl/src/nsNSSCertCache.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertCache.h,v  <--  nsNSSCertCache.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHeader.h,v
done
Checking in security/manager/ssl/src/nsNSSCertHeader.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHeader.h,v  <-- 
nsNSSCertHeader.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHelper.cpp,v
done
Checking in security/manager/ssl/src/nsNSSCertHelper.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHelper.cpp,v  <-- 
nsNSSCertHelper.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHelper.h,v
done
Checking in security/manager/ssl/src/nsNSSCertHelper.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertHelper.h,v  <-- 
nsNSSCertHelper.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertTrust.cpp,v
done
Checking in security/manager/ssl/src/nsNSSCertTrust.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertTrust.cpp,v  <-- 
nsNSSCertTrust.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertTrust.h,v
done
Checking in security/manager/ssl/src/nsNSSCertTrust.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertTrust.h,v  <--  nsNSSCertTrust.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertValidity.cpp,v
done
Checking in security/manager/ssl/src/nsNSSCertValidity.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertValidity.cpp,v  <-- 
nsNSSCertValidity.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertValidity.h,v
done
Checking in security/manager/ssl/src/nsNSSCertValidity.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertValidity.h,v  <-- 
nsNSSCertValidity.h
initial revision: 1.1
done
Checking in security/manager/ssl/src/nsNSSCertificate.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificate.cpp,v  <-- 
nsNSSCertificate.cpp
new revision: 1.93; previous revision: 1.92
done
Checking in security/manager/ssl/src/nsNSSCertificate.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificate.h,v  <-- 
nsNSSCertificate.h
new revision: 1.26; previous revision: 1.25
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificateDB.cpp,v
done
Checking in security/manager/ssl/src/nsNSSCertificateDB.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificateDB.cpp,v  <-- 
nsNSSCertificateDB.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificateDB.h,v
done
Checking in security/manager/ssl/src/nsNSSCertificateDB.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificateDB.h,v  <-- 
nsNSSCertificateDB.h
initial revision: 1.1
done
Checking in security/manager/ssl/src/nsNSSComponent.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSComponent.cpp,v  <-- 
nsNSSComponent.cpp
new revision: 1.89; previous revision: 1.88
done
Checking in security/manager/ssl/src/nsNSSHelper.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSHelper.h,v  <--  nsNSSHelper.h
new revision: 1.5; previous revision: 1.4
done
Checking in security/manager/ssl/src/nsNSSIOLayer.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSIOLayer.cpp,v  <--  nsNSSIOLayer.cpp
new revision: 1.77; previous revision: 1.76
done
Checking in security/manager/ssl/src/nsNSSModule.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSModule.cpp,v  <--  nsNSSModule.cpp
new revision: 1.27; previous revision: 1.26
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsOCSPResponder.cpp,v
done
Checking in security/manager/ssl/src/nsOCSPResponder.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsOCSPResponder.cpp,v  <-- 
nsOCSPResponder.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsOCSPResponder.h,v
done
Checking in security/manager/ssl/src/nsOCSPResponder.h;
/cvsroot/mozilla/security/manager/ssl/src/nsOCSPResponder.h,v  <-- 
nsOCSPResponder.h
initial revision: 1.1
done
Checking in security/manager/ssl/src/nsPK11TokenDB.h;
/cvsroot/mozilla/security/manager/ssl/src/nsPK11TokenDB.h,v  <--  nsPK11TokenDB.h
new revision: 1.3; previous revision: 1.2
done
Checking in security/manager/ssl/src/nsPKCS11Slot.h;
/cvsroot/mozilla/security/manager/ssl/src/nsPKCS11Slot.h,v  <--  nsPKCS11Slot.h
new revision: 1.2; previous revision: 1.1
done
Checking in security/manager/ssl/src/nsPKCS12Blob.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsPKCS12Blob.cpp,v  <--  nsPKCS12Blob.cpp
new revision: 1.30; previous revision: 1.29
done
Checking in security/manager/ssl/src/nsPKCS12Blob.h;
/cvsroot/mozilla/security/manager/ssl/src/nsPKCS12Blob.h,v  <--  nsPKCS12Blob.h
new revision: 1.8; previous revision: 1.7
done
Checking in security/manager/ssl/src/nsSDR.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsSDR.cpp,v  <--  nsSDR.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in security/manager/ssl/src/nsSDR.h;
/cvsroot/mozilla/security/manager/ssl/src/nsSDR.h,v  <--  nsSDR.h
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsUsageArrayHelper.cpp,v
done
Checking in security/manager/ssl/src/nsUsageArrayHelper.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsUsageArrayHelper.cpp,v  <-- 
nsUsageArrayHelper.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/security/manager/ssl/src/nsUsageArrayHelper.h,v
done
Checking in security/manager/ssl/src/nsUsageArrayHelper.h;
/cvsroot/mozilla/security/manager/ssl/src/nsUsageArrayHelper.h,v  <-- 
nsUsageArrayHelper.h
initial revision: 1.1
done
Checking in mailnews/extensions/smime/resources/content/certFetchingStatus.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/certFetchingStatus.js,v
 <--  certFetchingStatus.js
new revision: 1.3; previous revision: 1.2
done
Checking in mailnews/extensions/smime/resources/content/msgCompSecurityInfo.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgCompSecurityInfo.js,v
 <--  msgCompSecurityInfo.js
new revision: 1.4; previous revision: 1.3
done
Checking in mailnews/extensions/smime/resources/content/msgReadSecurityInfo.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgReadSecurityInfo.js,v
 <--  msgReadSecurityInfo.js
new revision: 1.6; previous revision: 1.5
done
Checking in mailnews/extensions/smime/src/nsMsgComposeSecure.cpp;
/cvsroot/mozilla/mailnews/extensions/smime/src/nsMsgComposeSecure.cpp,v  <-- 
nsMsgComposeSecure.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in mailnews/extensions/smime/src/nsMsgComposeSecure.h;
/cvsroot/mozilla/mailnews/extensions/smime/src/nsMsgComposeSecure.h,v  <-- 
nsMsgComposeSecure.h
new revision: 1.6; previous revision: 1.5
done
Checking in mailnews/mime/src/mimecms.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimecms.cpp,v  <--  mimecms.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in mailnews/mime/src/mimecms.h;
/cvsroot/mozilla/mailnews/mime/src/mimecms.h,v  <--  mimecms.h
new revision: 1.4; previous revision: 1.3
done
Checking in mailnews/mime/src/mimemcms.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimemcms.cpp,v  <--  mimemcms.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in mailnews/mime/src/mimemcms.h;
/cvsroot/mozilla/mailnews/mime/src/mimemcms.h,v  <--  mimemcms.h
new revision: 1.4; previous revision: 1.3
done

Comment 14

[Kai Engert [:KaiE:]]

Marking fixed.

Comment 15

[Darin Fisher]

kaie: i don't mean to make more work for you, but have you considered replacing
|wstring| with |AString| in these interfaces?

Comment 16

[Kai Engert [:KaiE:]]

> kaie: i don't mean to make more work for you, but have you considered replacing
> |wstring| with |AString| in these interfaces?

I filed bug 169932

Comment 17

[John Unruh]

Verified per kai's comment.