1684524 - Searching for download items, pressing Ctrl-A, and selecting "Remove from History" will remove all download items instead of just filtered ones

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Kyungjoon Lee]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

0. Fill Downloads list with downloads
1. Open Downloads list
2. Search for a download using the search box, to filter downloads
3. Click on a download then press Ctrl-A (or Cmd-A on Mac) to select all filtered downloads
4. Right-click and click on "Remove from History"

Actual results:

All downloads (even ones which were not visible) are deleted.

Expected results:

Only the visible downloads should be deleted.

Comment 1

[Kyungjoon Lee]

It's as if Ctrl-A selects all downloads, not just the visible ones.

Comment 2

[:Gijs (he/him)]

(In reply to Kyungjoon Lee from comment #1)

It's as if Ctrl-A selects all downloads, not just the visible ones.

Indeed, this appears to be what happens. :-(

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1684524 - Selecting all downloads after a search should not select excluded downloads. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac653d664162
Selecting all downloads after a search should not select excluded downloads. r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ac653d664162

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ac653d664162

Comment 7

[Daniel Bodea [:danibodea]]

I have reproduced this issue in Release v85.0 on Windows 10. The Mac OS and Ubuntu OS do not actually reproduce the original issue because (before the fix) there wasn't an option to select more than one downloaded files and remove them from history, however, it is now possible due to this bug fix so the behavior is identical between the three operating systems in the fixed builds.

Comment 8

[Kyungjoon Lee]

(In reply to Bodea Daniel [:danibodea] from comment #7)

[...] The Mac OS and Ubuntu OS do not actually reproduce the original issue [...]

JFYI I could reproduce the original issue on macOS before reporting it, using Cmd-A.

Comment 9

[Kyungjoon Lee]

(In reply to Bodea Daniel [:danibodea] from comment #7)

[...] (before the fix) there wasn't an option to select more than one downloaded files and remove them from history [...]

JFYI I could filter, select the first item, then scroll to bottom, then shift-click the last item, to select and remove all visible items after filtering. Selecting multiple items was also possible through Ctrl-Click, etc.