168455 - RTL text with position: relative not reordered on display

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Eyal Rozenberg]

The attachment file contains two lines of Hebrew text (encoding windows-1255,
e.g. logical, not visual); one of them is rendered properly (i.e. in the
right-aligned line, the first character of the first word appears first on the
right, then the second char of the first word etc). The next line is rendered in
reverse. Apparently when the 'position: relative' is removed the rendering is
proper.

Comment 1

[Eyal Rozenberg]

Attachment: a improperly-rendered two-hebrew-lines html file

Oh, forgot to mention my build is 2002-09-11-10 (but it was the same for a few
earlier builds I had too).

Comment 2

[Simon Montagu :smontagu]

Confirming on Windows and Linux. 

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch v.1

Good catch: we weren't including positionedInlineFrame in the list of frames
whose children we need to look at when collecting text from a block element to
pass to the Bidi reordering algorithm.

Adding positionedInlineFrame to the condition solves the problem with this test
case, but maybe there is a simpler and/or more general solution?

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 99147 [details] [diff] [review]
Patch v.1

r=dbaron

Comment 5

[kinmoz]

Comment on attachment 99147 [details] [diff] [review]
Patch v.1

sr=[e-mail]

Comment 6

[Simon Montagu :smontagu]

Fix checked in.

Comment 7

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).