1684593 - [wpt-sync] Sync PR 27023 - Implement style support for ::spelling-error + ::grammar-error

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27023 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27023
Details from upstream follow.

b'Delan Azabani <[e-mail]>' wrote:

Implement style support for ::spelling-error + ::grammar-error

This implements the style support only, behind a flag, based on the
::target-text counterpart in <https://crrev.com/c/2463563>.

The paint code for querying these selectors and paint invalidation,
as well as the changes needed to limit the acceptable properties (à
la <https://crrev.com/c/2489657>), will be written in another CL.

Bug: 1035708
Change-Id: I77e530fbbb78fb20c05325ef75babde91e5ef831

Reviewed-on: https://chromium-review.googlesource.com/2606878
WPT-Export-Revision: 6a2574adf9f49c1e841510988d5df6c09de85f3e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cfd7b6f9d1eedbc8c95bb9b20df1c77a3b963a0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 40 subtests

Status Summary

Firefox

OK : 2
PASS: 28
FAIL: 16

Chrome

OK : 2
PASS: 32
FAIL: 12

Safari

OK : 2
PASS: 28
FAIL: 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/highlight-pseudos-computed.html
getComputedStyle() for ::selection: FAIL (Chrome: FAIL, Safari: FAIL)
getComputedStyle() for ::target-text: FAIL (Chrome: FAIL, Safari: FAIL)
getComputedStyle() for ::spelling-error: FAIL (Chrome: FAIL, Safari: FAIL)
getComputedStyle() for ::grammar-error: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/parsing/highlight-pseudos.html
"::target-text" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
".a::target-text" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
"div ::target-text" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
"::part(my-part)::target-text" should be a valid selector: FAIL (Chrome: PASS, Safari: FAIL)
"::spelling-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
".a::spelling-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
"div ::spelling-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
"::part(my-part)::spelling-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
"::grammar-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
".a::grammar-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
"div ::grammar-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)
"::part(my-part)::grammar-error" should be a valid selector: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4385e6aeadf
[wpt PR 27023] - Implement style support for ::spelling-error + ::grammar-error, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0f7af81c0ba0
[wpt PR 27023] - Update wpt metadata, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c4385e6aeadf
https://hg.mozilla.org/mozilla-central/rev/0f7af81c0ba0