Closed
Bug 1684595
Opened 3 years ago
Closed 3 years ago
Delegate toggling CSSGridHighlighter from swatches in the Rules view
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox86 fixed)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(3 files)
Follow-up from Bug 1572652.
Following the example set in https://phabricator.services.mozilla.com/D96225 for the FlexboxHighlighter, move the logic to toggle the CSSGridHighlighter from clicking on swatches for display: grid in the Rules view from HighlightersOverlay to the Rules view itself.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D100563
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D100564
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ce4d0b47720 [devtools] Toggle grid highlighter from clicks on swatches in Rules view r=jdescottes https://hg.mozilla.org/integration/autoland/rev/c7d504ffb967 [devtools] Update the state of the swatch for grid highlighters from the Rules view r=jdescottes https://hg.mozilla.org/integration/autoland/rev/4c5a3eeb474d [devtools] Update tests for toggling the grid highlighter with the swatch from the Rules view r=jdescottes
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ce4d0b47720
https://hg.mozilla.org/mozilla-central/rev/c7d504ffb967
https://hg.mozilla.org/mozilla-central/rev/4c5a3eeb474d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•