Closed
Bug 1684637
Opened 4 years ago
Closed 4 years ago
CacheFile.cpp: do not use 'else' after 'return'
Categories
(Core :: Networking, task, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: deeps.garg71, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++][necko-triaged])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return'
https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/netwerk/cache2/CacheFile.cpp#231-296
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [lang=C++] → [lang=C++][necko-triaged]
|
||
Updated•4 years ago
|
Assignee: nobody → deeps.garg71
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b6d40edac93
CacheFile.cpp: do not use 'else' after 'return' r=necko-reviewers,dragana
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•