Closed
Bug 1684641
Opened 3 years ago
Closed 3 years ago
gtk3drawing.cpp: do not use 'else' after 'return'
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: anuragakellaak, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(2 files)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return'
https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/widget/gtk/gtk3drawing.cpp#3077-3085
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → anuragakellaak
Status: NEW → ASSIGNED
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/84b14eca730a fixed gtk3drawing.cpp: do not use 'else' after 'return' r=stransky
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
Reporter | |
Comment 4•3 years ago
|
||
|
|
||
Updated•3 years ago
|
Attachment #9195725 -
Attachment description: Bug 1684641 - followup fix - Remove useless braces r?stransky → Bug 1684641 - follow-up fix - Simplify the code by removing break; r?stransky
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2860b8d5bb6 follow-up fix - Simplify the code by removing break; r=stransky
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•