Closed Bug 1684647 Opened 9 months ago Closed 8 months ago

nsJSProtocolHandler.cpp: do not use 'else' after 'return'

Categories

(Core :: DOM: Core & HTML, task, P5)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: Sylvestre, Assigned: nirmay, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 2 obsolete files)

Filling as a good first bug to learn workflows.

do not use 'else' after 'return'
https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/dom/jsurl/nsJSProtocolHandler.cpp#314-317

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Assignee: nobody → nirmay.dhruv
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P5
Attachment #9196023 - Attachment is obsolete: true
Attachment #9195121 - Attachment is obsolete: true
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12ca98adf080
Removed 'else' after 'return'. r=nika
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.