1684673 - Some minor tweaks to class attribute handling.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684673 - Reorder some conditions when handling class/part attributes. r=#style

Empty class attributes are uncommon.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684673 - Use an AutoTArray for atom arrays in attributes (class / part). r=smaug

These are never empty, and storing 4 elements inline seems worth it
given we also heap-allocate the array itself.

Depends on D100592

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684673 - Inline nsTArray::deref. r=#style

This shaves >50ms if the compiler decides not to inline it, compilers are
sometimes dumb.

Depends on D100593

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a114ac95a42
Reorder some conditions when handling class/part attributes. r=xidorn

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87dc45811678
Inline nsTArray::deref. r=xidorn

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0a114ac95a42
https://hg.mozilla.org/mozilla-central/rev/87dc45811678

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a41340d05455
Use an AutoTArray for atom arrays in attributes (class / part). r=smaug

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a41340d05455