1684760 - Misc qcms cleanups

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Improve panic message.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Rename precache_output to PrecacheOutput.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Run cargo fmt.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Rename Intent enum variants.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Rename qcms_data_type to DataType.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Rename qcms_modular_transform to ModularTransform.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1684760 - Drop unneeded 'pub'.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/274e93cad0ad
Improve panic message. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/1e4eed52b335
Rename precache_output to PrecacheOutput. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/ac510617b3c9
Run cargo fmt. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/8238322901b7
Rename Intent enum variants. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/165f4be7a105
Rename qcms_data_type to DataType. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/7a6229521266
Rename qcms_modular_transform to ModularTransform. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/89fef9703703
Drop unneeded 'pub'. r=aosmond

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/274e93cad0ad
https://hg.mozilla.org/mozilla-central/rev/1e4eed52b335
https://hg.mozilla.org/mozilla-central/rev/ac510617b3c9
https://hg.mozilla.org/mozilla-central/rev/8238322901b7
https://hg.mozilla.org/mozilla-central/rev/165f4be7a105
https://hg.mozilla.org/mozilla-central/rev/7a6229521266
https://hg.mozilla.org/mozilla-central/rev/89fef9703703

Comment 10

[Alexandru Ionescu (needinfo me) [:alexandrui]]

:jrmuizel, is this expected to be caused by this bug?
== Change summary for alert #28485 (as of Mon, 18 Jan 2021 13:19:11 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	glterrain		windows10-64-shippable-qr	e10s stylo webrender	1.98 -> 2.05
2%	glterrain		windows10-64-shippable-qr	e10s stylo webrender	2.01 -> 2.05

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28485

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Nope. This should not have had a performance change.