1684792 - Form validation popups appear at a wrong place

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

STR;

1. Open https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#The_required_attribute
2. Push "submit" button

I don't quite understand why the validation popup window is opened in a different way.

Comment 1

[Neil Deakin]

The code in FormValidationChild.jsm and FormValidationParent.jsm needs to be adapted to use BrowserUtils.getElementBoundingScreenRect instead of getElementBoundingRect.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission M6c milestone like bug 1684795

Comment 3

[Neil Deakin]

Attachment: Bug 1684792, open form validation popup anchored at screen coordinate as datetime picker and select do so that it is positioned correctly in out of process iframes, r=gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f901a3b75b79
open form validation popup anchored at screen coordinate as datetime picker and select do so that it is positioned correctly in out of process iframes, r=Gijs

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=BGKr87duTHaiYiRYIZZb3Q.0&revision=d8b10014fae3d8d4907e2527b7bb618a66e4dcf1

Log: https://treeherder.mozilla.org/logviewer?job_id=326431159&repo=autoland&lineNumber=3491

Backout: https://hg.mozilla.org/integration/autoland/rev/dc12e9c08df2d6dfcfc0035d213a4dfd81b9121d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f866f5dc0058
open form validation popup anchored at screen coordinate as datetime picker and select do so that it is positioned correctly in out of process iframes, r=Gijs

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09efd72b0ce6
Backed out changeset f866f5dc0058 for causing failure on browser/browser_edit.js.

Comment 8

[Atila Butkovits]

Backed outfor causing failure on browser/browser_edit.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/09efd72b0ce68e0e2247c227c0b7446f21c95e33

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=XiGIvSn6RgOO5_n4nYmVuw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&searchStr=os%2Cx%2C10.14%2Cwebrender%2Copt%2Cmochitests%2Ctest-macosx1014-64-qr%2Fopt-mochitest-browser-chrome-e10s%2Cbc4&revision=f866f5dc0058c1ecf6c39786065b71c10699e624

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326787351&repo=autoland&lineNumber=3489

Comment 9

[Neil Deakin]

I am going to try to earlier version that forces the popup closed.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08990062babf
open form validation popup anchored at screen coordinate as datetime picker and select do so that it is positioned correctly in out of process iframes, r=Gijs

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/08990062babf