1684857 - DAMP test-head file should require the current `DAMP` instance

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

From https://phabricator.services.mozilla.com/D97732#inline-558464

DAMP's test head file has a mandatory initialize step that is called from damp.js: https://searchfox.org/mozilla-central/rev/2fcab997046ba9e068c5391dc7d8848e121d84f8/testing/talos/talos/tests/devtools/addon/content/tests/head.js#34-40

let damp = null;
/*
 * This method should be called by js before starting the tests.
 */
exports.initialize = function(_damp) {
  damp = _damp;
};

If damp.js would expose the current DAMP instance, the head.js file could simply require it.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1684857 - [devtools] Export current DAMP runner from damp.js

Depends on D97733

Exporting the current DAMP runner as a singleton from damp.js simplifies the dependency management between damp.js and head.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/655f3c4bd5a3
[devtools] Export current DAMP runner from damp.js r=ochameau,perftest-reviewers,kimberlythegeek

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 655f3c4bd5a3 (bug 1684857) for DUMP failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=325780409&repo=autoland

Push where failures showed:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=a41340d05455017826f66c78bf142e5aa53dbd16

Backout:
https://hg.mozilla.org/integration/autoland/rev/5043043054497c3cba4f65a7d60ed8fa72f763e8

Comment 4

[Julian Descottes [:jdescottes]]

With the change in this patch the same DAMP instance is reused for each test suite until the browser is closed. But currently DAMP doesn't support calling startTest twice. After the second run is done, when calling _doneInternal, we perform the following check:

    if (this._done) {
      return;
    }
    this._done = true;

https://searchfox.org/mozilla-central/rev/a0ccd492719b1ad2106f6456549be62a76f45acb/testing/talos/talos/tests/devtools/addon/content/damp.js#343-346

And since _done is not set to "false" again when calling startTest, the test hangs here. Let's see if resetting done is enough to fix DAMP: https://treeherder.mozilla.org/jobs?repo=try&revision=522d1226f2b1143ea7b63d385c44a48cd7957f5e

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4ed181f53e
[devtools] Export current DAMP runner from damp.js r=ochameau,perftest-reviewers,kimberlythegeek

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/be4ed181f53e