1684859 - [Enhancement] Consider enlarging the toggle's radius to include the title name

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

[Notes]:

• We already have this behavior on the about:preferences#home page and it would greatly help users that want to toggle the options.

[Affected versions]:

• Firefox Nightly 86.0a1, BuildID 20210104090857
• Firefox Beta 85.0b4, BuildID 20201220193140

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Prerequisites]:

• Have a new Firefox profile.
• Have the browser.newtabpage.activity-stream.newNewtabExperience.enabled pref set to true.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "Personalize" button.
3. Click the titles or the space to the right of the title and observe the cursor.

[Expected results]:

• The toggle is set to off.

[Actual results]:

• Nothing happens.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Erica & John, FYI.

Comment 2

[Erica Wright [:ewright]]

Attachment: Bug 1684859 - Connect titles and toggles, fix padding and font weight.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d2f4accf036
Connect titles and toggles, fix padding and font weight. r=prathiksha

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 0d2f4accf036 (Bug 1684859) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=RfRDvGG_TuW6bOCT5hKHUQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=0d2f4accf036e39b78b773641167e985e328f4d0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326469494&repo=autoland&lineNumber=103

Backout: https://hg.mozilla.org/integration/autoland/rev/9dede9aa3281f22603f4a9df42b9ecd94008060a

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6308e4a76f09
Backed out changeset 0d2f4accf036 for causing newtab failures CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed66d8e29b4b
Connect titles and toggles, fix padding and font weight. r=prathiksha

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ed66d8e29b4b

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "New Tab" page sections are successfully toggled on/off if the afferent title is clicked from the customize menu.

Verified using the latest Firefox Nightly (86.0a1 Build ID - 20210115035053) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.