1684887 - The "Sponsored stories" checkbox is wrongly displayed in the Customization panel in Regions where it shouldn't

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: sponsored stories option displayed in regions it shouldn't.gif

[Affected versions]:

• Firefox Nightly 86.0a1, BuildID 20210104090857
• Firefox Beta 85.0b4, BuildID 20201220193140

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Prerequisites]:

• Have an en-* Firefox build.
• Have a new Firefox profile with the following prefs set:
  • browser.newtabpage.activity-stream.newNewtabExperience.enabled pref set to true.
  • browser.search.region pref set to IN.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "Personalize" button.
3. Observe the available options.

[Expected results]:

• The "Shortcuts", "Recommended by Pocket", "Recent Activity", "Snippets" toggles, and "Row" dropdown menu are displayed.

[Actual results]:

• The "Sponsored stories" checkbox is also displayed.

[Notes]:

• The "Sponsored stories" checkbox is not available in the "about:preferences#home" page.
• The issue is not reproducible on regions where sponsored content is supported.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

FYI this looks like an issue with the new customization menu.

Comment 2

[Erica Wright [:ewright]]

Attachment: Bug 1684887 - Sponsored Stories checkbox hides when appropriate

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc56b4e8f5f
Sponsored Stories checkbox hides when appropriate r=thecount

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4fc56b4e8f5f

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ewright, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Erica Wright [:ewright]]

Comment on attachment 9195971 [details]
Bug 1684887 - Sponsored Stories checkbox hides when appropriate

Beta/Release Uplift Approval Request

• User impact if declined: This is preffed off in 85, however, we intend to run some user experiments in release on 85 on the customize menu. For these experiemnts it is important that this option does not show up at inappropriate times.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: change the pref browser.newtabpage.activity-stream.customizationMenu.enabled true
  change the pref browser.search.region to IN and restart the browser.
  open a new tab.
  click personalize to open the customization mene
  observe the "Recommended by Pocket" section, turn it on.
  The "sponsored pocket" checkbox in that section should no longer be an option.

when the browser.search.region is CA or other places where ads are available there should be a "sponsored pocket" checkbox. Keep in mind this needs a restart between changing this pref.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small JS patch, will only be used in experiments for this release.
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9195971 [details]
Bug 1684887 - Sponsored Stories checkbox hides when appropriate

approved for 85.0b8

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2da33062024a

Comment 9

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Firefox Nightly (86.0a1, BuildID 20210113043149) and the latest Firefox Beta (85.0b8, Build ID 20210112185508) using Windows 10, macOS 10.15.7, and Linux MX 4.19.