1684891 - sNativeKeyEventsMap leaks

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The object is autoreleased without an autorelease pool in place because it runs as a static constructor.

This was found by running with OBJC_DEBUG_MISSING_POOLS=YES LIBDISPATCH_DEBUG_MISSING_POOLS=NO

Comment 1

[Markus Stange [:mstange]]

It's a global map, so it's intended to "leak". But it's worth fixing it so that it doesn't trigger warnings.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1684891 - Stop allocating an autoreleased NSMutableDictionary from a C++ static initializer for sNativeKeyEventsMap. r=jrmuizel

There is no autorelease pool in place at the time that C++ globals are initialized, so this array
causes warnings when running with .
And avoiding static initializers is a good practice anyway.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adfa61d56f9c
Stop allocating an autoreleased NSMutableDictionary from a C++ static initializer for sNativeKeyEventsMap. r=jrmuizel

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/adfa61d56f9c