Closed Bug 1684896 Opened 4 years ago Closed 4 years ago

gAttributeGetters leaks in MacSelectorMap.mm

Categories

(Core :: Disability Access APIs, defect, P2)

Product:
Core
Component:
Disability Access APIs
Platform:
Desktop
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: jrmuizel, Assigned: mstange)

References

Details

(Whiteboard: [mac2020_2])

Attachments

(1 file)

Bug 1684896 - For the static NSDictionary MacSelectorMap objects, use function-local statics rather than globals. r=morgan
48 bytes, text/x-phabricator-request
Details | Review

The object is autoreleased without an autorelease pool in place because it runs as a static constructor.

This was found by running with OBJC_DEBUG_MISSING_POOLS=YES LIBDISPATCH_DEBUG_MISSING_POOLS=NO

Blocks: autorelease-leaks
Whiteboard: [mac2020_2]
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED

This means that the NSDictionaries will be constructed the first time the
wrapper function is called, and not at C++ static initializer time.
This avoids false positive warnings when running with the environment variables
OBJC_DEBUG_MISSING_POOLS=YES LIBDISPATCH_DEBUG_MISSING_POOLS=NO.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/f0767d452fc4
For the static NSDictionary MacSelectorMap objects, use function-local statics rather than globals. r=morgan

https://hg.mozilla.org/mozilla-central/rev/f0767d452fc4

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Component: Disability Access → Disability Access APIs
OS: Unspecified → macOS
Product: Firefox → Core
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: