Move debugging preferences from debugQA into SeaMonkey
Categories
(SeaMonkey :: Preferences, task)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.7)
Attachments
(6 files, 8 obsolete files)
|
13.89 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
8.29 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
6.45 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
5.42 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
26.84 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
10.43 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Majority of the preferences in debugQA are more to do with general debugging of SeaMonkey / website coding and would be useful in the full product rather than just betas, so let's move them into SeaMonkey.
Move the JavaScript / XUL debugging prefs into Advanced general pref pane and remove a defunct preference from that pane too. Directory listing format options are going away with RDF removal, so remove the pref.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: have to use about:config or debugQA extension to access the prefs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 15 strings moved from debugQA which will need localising, also 4 strings removed from defunct preference
Move modifier prefs to the Advanced -> Keyboard Navigation pane.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: have to use about:config or debugQA extension to access the prefs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 6 strings moved from debugQA that will need to be localised.
Move the memory/disk cache debug prefs into Advanced -> Cache pane.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: have to use about:config or debugQA extension to access the prefs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 5 strings moved from debugQA that will need localising.
Move event debugging pane from debugQA to a subpane of Advanced prefs.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: have to use about:config or debugQA extension to access the prefs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 13 new strings and 10 strings moved from debugQA, all will need localising.
This might need more work, but probably a reasonable starting point.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no help for new pref panes
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: help is all localised.
|
Assignee | |
Comment 10•5 years ago
|
||
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
|
Assignee | |
Comment 12•5 years ago
|
||
With this new set:
- moved the JavaScript prefs from Advanced to Scripts & Plugins panel
- rename Event Debugging to Debugging panel
- moved the XUL prefs from Advanced to Debugging panel
- put the printing prefs within a Printing groupbox on the Advanced panel
|
|
Assignee | |
Comment 13•5 years ago
|
||
Take up less space with additional cache prefs.
|
|
Assignee | |
Comment 14•5 years ago
|
||
As suggested, arrange debug prefs across two columns.
|
||
Comment 15•5 years ago
|
||
Comment on attachment 9198747 [details] [diff] [review]
1684948-debug-advanced-v1_1-2537.patch
LGTM
|
|
||
Comment 16•5 years ago
|
||
Comment on attachment 9198748 [details] [diff] [review]
1684948-debug-scripts-2537.patch
LGTM
|
|
||
Comment 17•5 years ago
|
||
Comment on attachment 9198749 [details] [diff] [review]
1684948-debug-accel-v1_1-2537.patch
LGTM
|
|
||
Comment 18•5 years ago
|
||
Comment on attachment 9198752 [details] [diff] [review]
1684948-debug-help-v1_1-2537.patch
help is fine bug if you press help in the debuggung prefs it shows the main help and not the debug prefs help. Probably needs to be added to the index for it. f+ so far.
|
|
||
Comment 19•5 years ago
|
||
Comment on attachment 9198881 [details] [diff] [review]
1684948-debug-cache-v1_2-2537.patch
LGTM
|
|
||
Comment 20•5 years ago
|
||
Comment on attachment 9198882 [details] [diff] [review]
1684948-debug-debugging-v1_2-2537.patch
LGTM
|
|
Assignee | |
Comment 21•5 years ago
|
||
Add entry to suite-toc to fix help button.
|
|
||
Comment 22•5 years ago
|
||
Comment on attachment 9199103 [details] [diff] [review]
1684948-debug-help-v1_2-2537.patch
LGTM
|
||
Comment 23•5 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/31ed4b7680e0
Move debugging preferences from debugQA into SeaMonkey - advanced prefs part. r=frg
https://hg.mozilla.org/comm-central/rev/97bf660130ec
Move debugging preferences from debugQA into SeaMonkey - scripts prefs part. r=frg
https://hg.mozilla.org/comm-central/rev/ec45cd5ee030
Move debugging preferences from debugQA into SeaMonkey - accelerator part. r=frg
https://hg.mozilla.org/comm-central/rev/e67496a9bc4d
Move debugging preferences from debugQA into SeaMonkey - cache part. r=frg
https://hg.mozilla.org/comm-central/rev/fbda0c116553
Move debugging preferences from debugQA into SeaMonkey - debugging part. r=frg
https://hg.mozilla.org/comm-central/rev/d5182b6919e1
Move debugging preferences from debugQA into SeaMonkey - help update. r=frg
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 24•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/93a9b67c80aa8d872b27be3ba2de59cf46c78482
Move debugging preferences from debugQA into SeaMonkey - advanced prefs part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/84f069eb4998658c09d2333cf3189322fc86dc11
Move debugging preferences from debugQA into SeaMonkey - scripts prefs part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fba8aaa213bd9e442c0b6363992144e42bc1cb59
Move debugging preferences from debugQA into SeaMonkey - accelerator part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/192464e009abcca977e3fe2b452fce7369b561f1
Move debugging preferences from debugQA into SeaMonkey - cache part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a7bb9f7a8574a670318c74e6e840f91ca54a1316
Move debugging preferences from debugQA into SeaMonkey - debugging part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7207ff45286fce827b2ef089b768d43b6513c580
Move debugging preferences from debugQA into SeaMonkey - help update. r=frg a=frg
Target 2.53.7
Description
•