Closed Bug 1684984 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27038 - [wpt] Fix position-sticky-nested-table.html

Categories

(Core :: Layout: Positioned, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27038 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27038
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

[wpt] Fix position-sticky-nested-table.html

wpt/css/css-position/sticky/position-sticky-nested-table.html test was
broken.
It failed in FF/Safari, and Chrome with TablesNG.

https://wpt.fyi/results/css/css-position/sticky/position-sticky-nested-table.html

The broken part of the test insterted an absolutely positioned
element as a sibling of every element with sticky position.
The abspos element is then positioned so that its position matches
sticky elements position.
I am not sure what this was testing.

This does not work for tables, because instertion of abspos sibling
to td element creates an anonymous table wrapper.
The anonymous wrapper becomes abspos container.

This CL removes creation of the abspos element. The test now passes
in all browsers.

Change-Id: I548afad533040509567ca24265306ace0d28d4cb
Reviewed-on: https://chromium-review.googlesource.com/2610190
WPT-Export-Revision: d7be2b67c5a0ce2af78b7100e8f30036138f7320

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e394534bfc8e [wpt PR 27038] - [wpt] Fix position-sticky-nested-table.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/ab28476d091b [wpt PR 27038] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.