1684991 - Start the RDD process early

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

In bug 1681043 ; we modified the startup procedure so that each process where decoding can happen will themselves check on what decoding capabilities are present.

This is then used by each content process to determine which process to use to decode a particular content.

For this work properly, the RDD process needs to be started early. Unfortunately, doing so causes exposes several problems in some tests (see https://bugzilla.mozilla.org/show_bug.cgi?id=1681043#c14)

One issue is with the sandbox on mac; when attempting to launch the RDD process it and to create the sandbox it crashes due to some variables not set yet.

And tests such as test_aboutmemory5.xhtml ; test_aboutmemory7.xhtml fail due to different expectations (the RDD process pid will now show in the output, which the test didn't account for)

Comment 1

[Cameron McCormack (:heycam)]

The memory reporter test failures: https://treeherder.mozilla.org/jobs?repo=try&revision=31484d3b6ced6876767be8a991875b80d2fe1cfb&selectedTaskRun=QgVe3DoWToGF-Rm-1K-BYQ.0

For test_aboutmemory5.xhtml, we might need to add something similar to this handling for the socket process:

https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/toolkit/components/aboutmemory/tests/test_aboutmemory5.xhtml#130

or to be more selective about which vsize entries we match out of the string.

For test_aboutmemory7.xhtml, to avoid the non-determinism from the RDD process ID (and whether the RDD process is present at all), we'll need to add a fake reporter for it here:

https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/toolkit/components/aboutmemory/tests/test_aboutmemory7.xhtml#32-51

and adjust the startExpected string (and perhaps have a version of it that includes the RDD process and one without).

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1684991 - Start the RDD process early.

This patch makes it so that we launch the RDD process relatively early
in the Firefox startup. This will improve the latency when we began
playback for the first video.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/742621410f46
Start the RDD process early. r=media-playback-reviewers,alwu

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/742621410f46