Closed Bug 1685053 Opened 3 years ago Closed 3 years ago

Allow ESLint's setup_helper.py to work when a dependency section is missing in package.json

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

In looking at updating to new module versions for ESLint, I noticed that the newer npm versions remove empty sections from package.json.

This currently breaks tools/lint/eslint/setup_helper.py as it assumes those sections will be present.

Hence I'd like to fix this now before I keep hitting it.

Geoff, please could you add the relevant testing policy flag?

Flags: needinfo?(whole.grains)

Sorry! Done.

Flags: needinfo?(whole.grains)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f0955391424
Fix ESLint's setup_helper.py to continue working when a dependency section is missing in package.json. r=gbrown
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: