1685140 - Noticeable UI lag when deleting lots of history entries because TopSitesFeed.refresh is called for every single one

Status: NEW

(Firefox :: Top Sites, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:86.0) Gecko/20100101 Firefox/86.0 ID:20210104172545

Here a profile with a recent Nightly that shows that certain Activity stream related code is running on the main thread and causing event processing delays:

https://share.firefox.dev/3pXH9Gp

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that this happened after I tried to remove all traces for a site via the history sidebar, which blocked the Firefox UI for nearly 80s (see bug 1458634).

Comment 2

[Scott [:thecount] Downe]

Do you think this might be a recent regressions?

Are you able to reproduce the jank consistently?

I got some help looking the perf profile, and it looks like a lot of this is happening in TopSitesFeed.getLinksWithDefaults so I think maybe moving this to the topsites component might be better.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I got it twice so far by trying to restore a local Firefox profile, which then get synced with Firefox accounts. Whereby the sync steps removed a lot of history items. I don't care which component that is in. So feel free to do what you think is best.

Comment 4

[Scott [:thecount] Downe]

Alright, going to try it in topsites component, and see if that helps. It might come back to newtab and that's fine.

Comment 5

[brad.bannon]

(In reply to Scott [:thecount] Downe from comment #2)

Do you think this might be a recent regressions?

Are you able to reproduce the jank consistently?

I got some help looking the perf profile, and it looks like a lot of this is happening in TopSitesFeed.getLinksWithDefaults so I think maybe moving this to the topsites component might be better.

Never digged into this, but I've seen this for a long time (probably since Firefox 50s or 60s versions).

I delete cache and cookies on a regular basis, but keep the browsing history usually for a couple of months. When deleting a web site with a small number of page visits deletion is fast, but when there are more entries (> 500) it takes minutes. I've attached a screenshot deleting my ebay.de history. It had about 600 subentries and took 4 minutes. Also notice I/O total rate that ProcessHacker reports (> 1GB).

Comment 6

[brad.bannon]

Attachment: firefox.png