1685279 - Change QuotaManager::ParseOrigin to return a Result<PrincipalInfo, nsresult>

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1685279 - Change QuotaManager::ParseOrigin to return a Result<PrincipalInfo, nsresult>. r=#dom-workers-and-storage

ParseOrigin is only used to construct a PrincipalInfo, so it makes sense to
return it directly.

This also fixes an inconsistency: While the callers always created a
ContentPrincipalInfo without checking the result, ParseOrigin was also able to
handle a chrome origin, which should have been turned into a SystemPrincipal.
Since this doesn't seem to be used, we now explicitly fail for a chrome origin.

Depends on D100888

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cc8da62b1a7
Change QuotaManager::ParseOrigin to return a Result<PrincipalInfo, nsresult>. r=dom-workers-and-storage-reviewers,janv

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9cc8da62b1a7