1685346 - Opt "Restart with addons disabled" dialog into the new window-modal UI

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Micah [:mtigley] (she/her)]

Attachment: Current "Restart with addons disabled" modal UI.png

The "Restart with addons disabled" modal should use a new window-modal UI.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

As pointed out on matrix, now that the two other dialogs (refresh and startup cache) are using the new style, it looks incongruous for the other dialog to use the old style of prompting.

This should involve making the method containing https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/browser/components/BrowserGlue.jsm#1442 async, adding a window argument to it and using window.browsingContext instead of null as the first argument to asyncConfirmEx. To get the window argument, we should teach the places where we dispatch the "restart-in-safe-mode" notification to pass their window as the first (subject) param to notifyObservers, and https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/browser/components/BrowserGlue.jsm#1027 to pass that argument on.

Comment 3

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1685346 - Opt "Restart with addons disabled" dialog into the new window-modal UI r?Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27ade6b52cc5
Opt "Restart with addons disabled" dialog into the new window-modal UI r=Gijs

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/27ade6b52cc5

Comment 6

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly and Beta builds 89.0b2