Closed Bug 1685346 Opened 4 months ago Closed 1 month ago

Opt "Restart with addons disabled" dialog into the new window-modal UI

Categories

(Toolkit :: Add-ons Manager, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: mtigley, Assigned: michelle)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-modals] [priority:2b])

Attachments

(2 files)

The "Restart with addons disabled" modal should use a new window-modal UI.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Add-ons Manager
Product: Firefox → Toolkit
Severity: -- → N/A
Priority: -- → P2

As pointed out on matrix, now that the two other dialogs (refresh and startup cache) are using the new style, it looks incongruous for the other dialog to use the old style of prompting.

This should involve making the method containing https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/browser/components/BrowserGlue.jsm#1442 async, adding a window argument to it and using window.browsingContext instead of null as the first argument to asyncConfirmEx. To get the window argument, we should teach the places where we dispatch the "restart-in-safe-mode" notification to pass their window as the first (subject) param to notifyObservers, and https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/browser/components/BrowserGlue.jsm#1027 to pass that argument on.

Severity: N/A → S2
Type: task → defect
Keywords: helpwanted
OS: Unspecified → All
Priority: P2 → --
Hardware: Unspecified → Desktop
Summary: Verify "Restart with addons disabled" modal uses new window-modal UI → Opt "Restart with addons disabled" dialog into the new window-modal UI
Whiteboard: [proton-modals] → [proton-modals] [priority:2b]
Priority: -- → P2
Assignee: nobody → michelle
Attachment #9214712 - Attachment description: WIP: Bug 1685346 - Opt "Restart with addons disabled" dialog into the new window-modal UI r?Gijs → Bug 1685346 - Opt "Restart with addons disabled" dialog into the new window-modal UI r?Gijs
Status: NEW → ASSIGNED
Pushed by michelle@masterwayz.nl:
https://hg.mozilla.org/integration/autoland/rev/27ade6b52cc5
Opt "Restart with addons disabled" dialog into the new window-modal UI r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

This issue is Verified as fixed in our latest Nightly and Beta builds 89.0b2

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.