1685364 - PDMFactory.cpp:681:7: error: use of undeclared identifier 'AOMDecoder', when building with --disable-av1

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Building with this in my mozconfig, on mac...

ac_add_options --enable-debug --enable-optimize
ac_add_options --disable-av1

...I get this build error:

dom/media/platforms/PDMFactory.cpp:681:7: error: use of undeclared identifier 'AOMDecoder'
 0:09.52   if (AOMDecoder::IsAV1(aMimeType)) {
 0:09.52       ^

This seems to be pointing to a line that was added in bug 1681043.

(I have --disable-av1 in my mozconfig because it was required at some point recently in order to work around some other build error.)

Comment 1

[Daniel Holbert [:dholbert]]

This probably needs to be wrapped in #ifdef MOZ_AV1, I'm guessing.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1685364: Add ifdef guard around some AV1-specific code, to fix --disable-av1 build bustage. r?alwu

Comment 3

[Petr Sumbera]

Isee the same on Solaris.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e416d9b99a9
Add ifdef guard around some AV1-specific code, to fix --disable-av1 build bustage. r=alwu

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9e416d9b99a9

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1681043