Closed Bug 1685390 Opened 5 years ago Closed 5 years ago

Apilint fails with KeyError: 'error' if api version is out of date

Categories

(GeckoView :: General, defect, P3)

Unspecified
All
defect

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: agi, Assigned: agi)

Details

Attachments

(1 file)

Just noticed this: https://treeherder.mozilla.org/jobs?repo=try&revision=596ed0ec000baef86331d11d75c4085c37da10c4&selectedTaskRun=Jb8tj5Y7QAS6HBd1E3gaDg.0

Looks like we're missing a error key in the result json.

task 2021-01-06T18:25:32.989Z] BUILD SUCCESSFUL in 19s
[task 2021-01-06T18:25:32.989Z] 1 actionable task: 1 executed
[task 2021-01-06T18:25:33.378Z] Traceback (most recent call last):
[task 2021-01-06T18:25:33.379Z]   File "/builds/worker/checkouts/gecko/python/mozlint/mozlint/roller.py", line 64, in _run_worker
[task 2021-01-06T18:25:33.379Z]     res = func(paths, config, **lintargs) or []
[task 2021-01-06T18:25:33.379Z]   File "/builds/worker/checkouts/gecko/python/mozlint/mozlint/types.py", line 57, in __call__
[task 2021-01-06T18:25:33.380Z]     return self._lint(paths, config, **lintargs)
[task 2021-01-06T18:25:33.380Z]   File "/builds/worker/checkouts/gecko/python/mozlint/mozlint/types.py", line 169, in _lint
[task 2021-01-06T18:25:33.380Z]     return func(config, **lintargs)
[task 2021-01-06T18:25:33.380Z]   File "/builds/worker/checkouts/gecko/tools/lint/android/lints.py", line 114, in api_lint
[task 2021-01-06T18:25:33.380Z]     "level": "error" if r["error"] else "warning",
[task 2021-01-06T18:25:33.380Z] KeyError: 'error'
Assignee: nobody → agi
Status: NEW → ASSIGNED
Severity: -- → S4
Priority: -- → P3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: