1685503 - Use AwakeTimeStamp to count time for media telemetry

Status: RESOLVED FIXED

(Core :: Audio/Video, task)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1685503 - Switch HTMLMediaElement telemetry to use AwakeTimeStamp. r?mattwoodrow

This prevents having dramatic over-reporting on Windows.

Depends on D101036

Comment 2

[Alastor Wu [:alwu]]

That is not actual a blocker, but we have to be aware of which bug would be landed first, then another bug would need to do some rebasing. So change it to see-also.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1685503 - Use AwakeTimeStamp to count time for media telemetry. r?alwu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36427e64399a
Use AwakeTimeStamp to count time for media telemetry. r=alwu

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/260d3cdf51bcd92bcfa21fce02a12c3703874706

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc141a334421
Use AwakeTimeStamp to count time for media telemetry. r=alwu

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e339980fb66f
Backed out changeset bc141a334421 for windows browser chrome failures on browser_tab_visibility_and_play_time.js CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for windows browser chrome failures on browser_tab_visibility_and_play_time.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=73de0ec210e6ae9b78b815b26243e1c7fbcc9184&tochange=e339980fb66f4025e5171dfe2baa7a4706a08161&searchStr=bc&test_paths=dom%2Fmedia%2Ftest%2Fbrowser&selectedTaskRun=AVA-3NGRTFe65RwRArcgFQ.0

Backfills: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunning%2Cpending%2Crunnable&fromchange=73de0ec210e6ae9b78b815b26243e1c7fbcc9184&tochange=e339980fb66f4025e5171dfe2baa7a4706a08161&searchStr=windows%2C7%2Copt%2Cmochitests%2Ctest-windows7-32%2Fopt-mochitest-browser-chrome-e10s%2Cbc5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=338176429&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e339980fb66f4025e5171dfe2baa7a4706a08161

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1685503 - Wait for "timeupdate", or one second (when paused) when testing the telemetry probes for visible and invisible media elements, to not depend on high-resolution clock. r?alwu

This patch moves to a lower-resolution clock on Windows, so this was failing.

Depends on D112797

Comment 10

[Paul Adenot (:padenot)]

Alastor, I still have a failure (even with the path that adds sleeps) that I don't understand: https://treeherder.mozilla.org/jobs?repo=try&revision=16474cd2909a408eb4796ba814d59e6947c6441c, do you?

Comment 11

[Alastor Wu [:alwu]]

I will check that later today, keep my NI.

Comment 12

[Alastor Wu [:alwu]]

I tried your patch locally and ran it many times (50+), the result all seemed pretty good. If we still get the intermittent failure on try, that means the low resolution clock didn't continue counting within a second, is that something we need to worry about?

Or we could try to use waitForCondition(/* callback : return true when the clock starts forward*/) to replace the sleep() in assertValueConstantlyIncreases to see if the result would become more reliable.

Comment 13

[Paul Adenot (:padenot)]

(In reply to Alastor Wu [:alwu] from comment #12)

Or we could try to use waitForCondition(/* callback : return true when the clock starts forward*/) to replace the sleep() in assertValueConstantlyIncreases to see if the result would become more reliable.

That was it, thanks for the hint, I switched this to use "timeupdate" (when playing, kept setTimeout for the "paused" case), and it's solidly green. It's just a matter of playback taking some time to start, which, in retrospect, is obvious:

https://treeherder.mozilla.org/jobs?repo=try&revision=24d983cc8699defb0827e94dbc60eed75157bb64&selectedTaskRun=EwK3VEQYTiSkkU0QEoWbWw.0

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/037395dc7d1d
Use AwakeTimeStamp to count time for media telemetry. r=alwu
https://hg.mozilla.org/integration/autoland/rev/cb5292b9c50d
Wait for "timeupdate", or one second (when paused) when testing the telemetry probes for visible and invisible media elements, to not depend on high-resolution clock. r=alwu

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/037395dc7d1d
https://hg.mozilla.org/mozilla-central/rev/cb5292b9c50d