1685662 - [MIPS] Some BigInt related tests failed on mips platform

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Comment 1

[Zhao Jiazhong]

On mips64 platform, some BitInt related jit-tests failed, like:

• bigint/bigint-add.js
• bigint/bigint-dec.js
• bigint/bigint-inc.js
• bigint/bigint-mul.js
• etc

And it's because some functions are not implemented on mips platform, which is introduced in bug 1679750. I will try to port the changes to mips64 platform.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1679750

Comment 3

[Zhao Jiazhong]

Attachment: Bug 1685662 - [MIPS] Implement MacroAssembler::branch{Add,Sub,Mul}Ptr. r=jandem

Port D98163, D98165, D98167 to mips platform.

Comment 4

[Liu Yu]

Attachment: Bug 1685662 - [MIPS] Implement some changes. r=jandem

Add convertDoubleToPtr, move32SignExtendToPtr, spectreBoundsCheckPtr and spectreMaskIndexPtr to the MacroAssembler;

Implement MacroAssembler::branch{Add,Sub,Mul}Ptr;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4111f26f0630
[MIPS] Implement some changes. r=jandem

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4111f26f0630

Comment 8

[Zhao Jiazhong]

It seems that this patch introduced an assert error due to misusing the scratch register. Currently, the scratch register usage on mips port is a mess, I will firstly fix this assert failure to make sure at least the tests pass.

Comment 9

[Zhao Jiazhong]

Attachment: Bug 1685662 - [MIPS64] Fix register conflict in ma_addPtrTestOverflow. r=lth

The rt operand may be the ScratchRegister and will cause an assert fail,
now change the implementation of the function to remove the assert.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9af325a1c3d
[MIPS64] Fix register conflict in ma_addPtrTestOverflow. r=lth

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b9af325a1c3d