Closed Bug 1685727 Opened 3 years ago Closed 3 years ago

TaskController cannot process task submitted during ShutdownXPCOM

Categories

(Core :: XPCOM, task)

Product:
Core
Component:
XPCOM
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: allstars.chh, Assigned: bas.schouten)

References

Details

Attachments

(1 file)

Bug 1685727: Ensure all the thread pool task queue has been cleared before shutting down. r=smaug
48 bytes, text/x-phabricator-request
Details | Review

My sample patch is https://gist.github.com/allstarschh/17eeab8c6f37a979e6eef649fab6c11d

During XPCOMShutdown, submit a Task to TaskController, and add assert in TaskController::RunPoolThread to make sure it processes all the tasks before returning.

However, the assertion failed.

During the shutdown, GC will perform many finalization operations so it needs the thread pool to handle these operations even during the shutdown.

Summary: TaskControll cannot process task submitted during ShutdownXPCOM → TaskController cannot process task submitted during ShutdownXPCOM
Assignee: nobody → bas
Status: NEW → ASSIGNED
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/145a15ffc8d2
Ensure all the thread pool task queue has been cleared before shutting down. r=smaug

https://hg.mozilla.org/mozilla-central/rev/145a15ffc8d2

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: