1685738 - Remove no longer used non-boxed output code in CacheIRCompiler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[André Bargull [:anba]]

There are a couple of if (!output.hasValue()) { ... } blocks in CacheIRCompiler which are no longer taken, because the output is nowadays always boxed.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 1: Remove no longer used non-boxed output code for LoadDenseElementHoleResult and LoadTypedArrayElementResult. r=jandem!

Get{Prop,Elem}{Super} are now always using boxed outputs, so we can remove
the non-boxed output code for LoadDenseElementHoleResult and
LoadTypedArrayElementResult.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 2: Directly store boxed results in various GetProp/GetElem/Call CacheIR instructions. r=jandem!

Get{Prop,Elem}{Super} and Call instructions are always using boxed results,
so instead of calling EmitStoreResult we can directly call masm.tagValue().

Depends on D101185

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 3: Directly store result for unary/binary arithmetic as boxed value. r=jandem!

Similar to part 2, we can directly call masm.tagValue() instead of (sometimes!)
going through EmitStoreResult.

Depends on D101186

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 4: Remove unreachable code from CacheIRCompiler::emitLoadXXXResult. r=jandem!

Undefined/String/Symbol/Int32/BigInt results are always boxed, so we don't need
to go through EmitStoreResult.

Drive-by change:

• Call EmitStoreResult for LoadObjectResult.

Depends on D101187

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 5: Remove method declarations without definitions. r=jandem!

Depends on D101188

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 6: Make check for negative indices explicit. r=jandem!

Instead of relying on uint32_t(negative_int32) being larger the ArrayBuffer
length, explicitly check for negative indices.

Depends on D101189

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1685738 - Part 7: Ensure IonCacheIRCompiler has test coverage for GetPropSuper/OptimizeSpread/ToPropertyKey. r=jandem!

Code coverage showed we have no coverage for these instructions when running with ICs.

Depends on D101190

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c16133926f0
Part 1: Remove no longer used non-boxed output code for LoadDenseElementHoleResult and LoadTypedArrayElementResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/1a07d40ea891
Part 2: Directly store boxed results in various GetProp/GetElem/Call CacheIR instructions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/05d7da0993b8
Part 3: Directly store result for unary/binary arithmetic as boxed value. r=jandem
https://hg.mozilla.org/integration/autoland/rev/dfe94c90b6aa
Part 4: Remove unreachable code from CacheIRCompiler::emitLoadXXXResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/2e262a8ce00f
Part 5: Remove method declarations without definitions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b83ade0f6c64
Part 6: Make check for negative indices explicit. r=jandem
https://hg.mozilla.org/integration/autoland/rev/cf1f775c0cdd
Part 7: Ensure IonCacheIRCompiler has test coverage for GetPropSuper/OptimizeSpread/ToPropertyKey. r=jandem

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8c16133926f0
https://hg.mozilla.org/mozilla-central/rev/1a07d40ea891
https://hg.mozilla.org/mozilla-central/rev/05d7da0993b8
https://hg.mozilla.org/mozilla-central/rev/dfe94c90b6aa
https://hg.mozilla.org/mozilla-central/rev/2e262a8ce00f
https://hg.mozilla.org/mozilla-central/rev/b83ade0f6c64
https://hg.mozilla.org/mozilla-central/rev/cf1f775c0cdd