Closed Bug 1685801 Opened 2 years ago Closed 2 years ago

Move most things out of BrowserUtils.jsm

Categories

(Toolkit :: General, task, P2)

task

Tracking

()

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

BrowserUtils.jsm is loaded in all processes, but most of it is only needed in the parent. It should be stripped down as much as possible.

Note that PromptUtils.objectToPropBag and the new propBagToObject function in
prompt_common.js do not do the recursive conversion that the BrowserUtils
versions attempted, but that code was completely broken, and would have failed
if it encountered a value which triggered recursion.

It's only used by the finder code, and can be much simpler.

It won't ever be used in most content processes.

It will mostly not be used. This patch just duplicates it in the two modules
that use it since it's not long for this world, anyway.

This moves the exception prettifying to the script security manager for all JS
callers, where it is much cheaper and more consistently applied.

Severity: -- → S3
Status: NEW → ASSIGNED
Fission Milestone: --- → M7
Priority: -- → P2
Attachment #9196644 - Attachment description: Bug 1685801: Part 10 - Move BrowserUtils.getElementtBounding*Rect to a separate module. r=mccr8 → Bug 1685801: Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d9f1feba9454
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/14e4e47ee99f
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/fa814f4b7125
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/8007b12d6e32
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/30786893a5e7
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a80de9abb9f8
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3f4dc6349441
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9d51c6e24dee
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0ce3c773ba74
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2c1250e786f0
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5175062925c7
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/0d7153110519
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8
Backout by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9058c70634b
Backed out 12 changesets for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/edf6209861a8
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b91098299143
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a49415007aaf
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/338ab91af557
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0c358ee51951
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ee0d0169b079
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7dfcf0257487
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b267b19a7f6e
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/1a7f259cc2ec
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9ab9574ac72a
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/38cc10101c1f
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/021924b62f13
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8
Flags: needinfo?(kmaglione+bmo)
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60f948492e6c
Backed out 12 changesets for causing bc failures in browser_ctrlTab.js
Flags: needinfo?(kmaglione+bmo)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/48e72e2fe184
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/85147dd0a1cc
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d1e122651111
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2e0fe366d6c0
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e75da77e19ac
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/11c9171434b7
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7eca8293846d
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3f912d15c129
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a0572c936024
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7c1f3e4fbffd
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4ba93ae387f2
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/f5d08efaa765
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8
See Also: → 1689635
See Also: → 1694173
Regressions: 1694173
You need to log in before you can comment on or make changes to this bug.