1685801 - Move most things out of BrowserUtils.jsm

Status: RESOLVED FIXED

(Toolkit :: General, task, P2)

Description

[Kris Maglione [:kmag]]

BrowserUtils.jsm is loaded in all processes, but most of it is only needed in the parent. It should be stripped down as much as possible.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8

Note that PromptUtils.objectToPropBag and the new propBagToObject function in
prompt_common.js do not do the recursive conversion that the BrowserUtils
versions attempted, but that code was completely broken, and would have failed
if it encountered a value which triggered recursion.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 2 - Move site origin telemetry to separate module. r=mccr8

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 4 - Remove BrowserUtils.dumpLn. r=mccr8

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 5 - Remove BrowserUtils.restartApplication. r=mccr8

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8

It's only used by the finder code, and can be much simpler.

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8

It won't ever be used in most content processes.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8

They won't be used in most processes.

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 11 - Move makeNicePluginName out of BrowserUtils. r=mccr8

It will mostly not be used. This patch just duplicates it in the two modules
that use it since it's not long for this world, anyway.

Comment 12

[Kris Maglione [:kmag]]

Attachment: Bug 1685801: Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8

This moves the exception prettifying to the script security manager for all JS
callers, where it is much cheaper and more consistently applied.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9f1feba9454
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/14e4e47ee99f
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/fa814f4b7125
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/8007b12d6e32
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/30786893a5e7
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a80de9abb9f8
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3f4dc6349441
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9d51c6e24dee
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0ce3c773ba74
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2c1250e786f0
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5175062925c7
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/0d7153110519
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9058c70634b
Backed out 12 changesets for causing failures on browser_fission_maxOrigins.js. CLOSED TREE

Comment 15

[Atila Butkovits]

Backed out for causing failures on browser_fission_maxOrigins.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c9058c70634bb051c37a87eaa03c91f2b38aee97

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Copt%2Cmochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc2&revision=0d7153110519458cd6c37d4191f6ee4a17ec1bd3&selectedTaskRun=PoKSEaNdRpOZbiZHuTBmvg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=328048144&repo=autoland&lineNumber=5295

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edf6209861a8
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b91098299143
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a49415007aaf
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/338ab91af557
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0c358ee51951
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/ee0d0169b079
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7dfcf0257487
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b267b19a7f6e
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/1a7f259cc2ec
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/9ab9574ac72a
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/38cc10101c1f
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/021924b62f13
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8

Comment 17

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60f948492e6c
Backed out 12 changesets for causing bc failures in browser_ctrlTab.js

Comment 18

[Alexandru Michis [:malexandru]]

Backed out 12 changesets (Bug 1685801) for causing bc failures in browser_ctrlTab.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/60f948492e6c

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=4837c1efc868542bec9107071809e481ade5e75c&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc6&tochange=021924b62f13e7f7210db20cfb06cc51b869fba7&selectedTaskRun=TiBcv-q7S-atGTC7awqmyw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=328116517&repo=autoland&lineNumber=14475

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48e72e2fe184
Part 1 - Move objectToPropBag and propBagToObject out of BrowserUtils. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/85147dd0a1cc
Part 2 - Move site origin telemetry to separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d1e122651111
Part 3 - Remove BrowserUtils.makeURI and makeFileURI. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2e0fe366d6c0
Part 4 - Remove BrowserUtils.dumpLn. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e75da77e19ac
Part 5 - Remove BrowserUtils.restartApplication. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/11c9171434b7
Part 6 - Move some front-end code from BrowserUtils to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7eca8293846d
Part 7 - Move BrowserUtils.parseUrlAndPostData to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3f912d15c129
Part 8 - Remove BrowserUtils toolbar tracking code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a0572c936024
Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7c1f3e4fbffd
Part 10 - Move BrowserUtils.getElementBounding*Rect to a separate module. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4ba93ae387f2
Part 11 - Move makeNicePluginName out of BrowserUtils. r=handyman
https://hg.mozilla.org/integration/autoland/rev/f5d08efaa765
Part 12 - Remove BrowserUtils.urlSecurityCheck. r=mccr8

Comment 20

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/48e72e2fe184
https://hg.mozilla.org/mozilla-central/rev/85147dd0a1cc
https://hg.mozilla.org/mozilla-central/rev/d1e122651111
https://hg.mozilla.org/mozilla-central/rev/2e0fe366d6c0
https://hg.mozilla.org/mozilla-central/rev/e75da77e19ac
https://hg.mozilla.org/mozilla-central/rev/11c9171434b7
https://hg.mozilla.org/mozilla-central/rev/7eca8293846d
https://hg.mozilla.org/mozilla-central/rev/3f912d15c129
https://hg.mozilla.org/mozilla-central/rev/a0572c936024
https://hg.mozilla.org/mozilla-central/rev/7c1f3e4fbffd
https://hg.mozilla.org/mozilla-central/rev/4ba93ae387f2
https://hg.mozilla.org/mozilla-central/rev/f5d08efaa765