1685823 - Preview updates twice when sheet count changes after changing printers

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Mark Striemer [:mstriemer]]

STR

1. Go to https://en.wikipedia.org/wiki/Firefox and print
2. Change your printer
3. Change the orientation (or zoom)

Expected results: Preview updates with the new orientation
Actual results: Preview updates with the new orientation then immediately updates again

This appears to be caused by the page range component and I suspect it has something to do with dispatching settings changes outside of the handleEvent method.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 499640

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1685823 - Only re-render preview on sheet count change when needed r?emalysz

Comment 3

[Emil Ghitta, QA [:emilghitta]]

Attachment: scale.gif

This also seems to be reproducible while changing different scale options on this pdf document

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8db7af1b3397
Only re-render preview on sheet count change when needed r=emalysz

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_print_page_range.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/e1b9d71635ff4f128e0030103f0579f4e7cce15e
Log link: https://treeherder.mozilla.org/logviewer?job_id=326723517&repo=autoland&lineNumber=5203

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7c842f7a28
Only re-render preview on sheet count change when needed r=emalysz

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0a7c842f7a28

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Moving things to 88, cause we're mostly on Proton these days…