1685830 - Preload can't be used from a file:// URI.

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

While in other browsers it can.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685830 - Remove spurious check that prevents preload from working in non-http(s) sites. r=smaug

As it doesn't match other implementations, and it's confusing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/336d95146e8e
Remove spurious check that prevents preload from working in non-http(s) sites. r=smaug

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27123 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/336d95146e8e

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9196195 [details]
Bug 1685830 - Remove spurious check that prevents preload from working in non-http(s) sites. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: Potential preload interop issue (preload was enabled in 84)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Remove if(not http) return :-)
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9196195 [details]
Bug 1685830 - Remove spurious check that prevents preload from working in non-http(s) sites. r=smaug

This sounds like a rather obscure issue, not convinced it can't ride the trains.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

It can also affect data: uris and about:blank, which makes me a bit more worried... But you're right we haven't seen this on the wild yet.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot