Use object literal for JSON dump for array where its elements are referred by index
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(11 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
stencil's JSON dump currently uses list (array) for vector/span,
but some of them are referred by index (RegExp, Scope, etc).
it's better dumping them as following:
"ScopeData": {
"ScopeIndex(0)": {
"kind": "global",
...
},
"ScopeIndex(1)": {
"kind": "lexical",
...
}
}
so that the reference like the following is clearer which item it points:
"gcThings": [
"ScopeIndex(0)",
"ScopeIndex(1)"
],
Comment 1•5 years ago
•
|
||
While you are here, can you add the missing args.rval().setUndefined();
to https://searchfox.org/mozilla-central/rev/dd7de907becd732c4d9f4ac321a911e6466e8144/js/src/shell/js.cpp#5578
Currently there is an extra function dumpStencil() { [native code] }
message in the shell
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D101837
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D101838
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D101839
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D101840
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D101841
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D101843
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D101844
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D101845
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D101846
Assignee | ||
Comment 12•5 years ago
|
||
Depends on D101847
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f4632de3fbef
https://hg.mozilla.org/mozilla-central/rev/cc26e1db4187
https://hg.mozilla.org/mozilla-central/rev/0890bbb50268
https://hg.mozilla.org/mozilla-central/rev/38ec7ac8084a
https://hg.mozilla.org/mozilla-central/rev/c9e9d57a8815
https://hg.mozilla.org/mozilla-central/rev/268730dc367e
https://hg.mozilla.org/mozilla-central/rev/f79d48597efc
https://hg.mozilla.org/mozilla-central/rev/6df8537b71d5
https://hg.mozilla.org/mozilla-central/rev/c18597050dd5
https://hg.mozilla.org/mozilla-central/rev/f7e5d9c17630
https://hg.mozilla.org/mozilla-central/rev/91371e0589f2
Description
•