Closed Bug 1685986 Opened 4 years ago Closed 4 years ago

Enable ESLint of gfx/wr/debugger/ where possible

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

Bug 1685948 is enabling ESLint of most of gfx/wr but not the gfx/wr/debugger directory.

We can fairly easily enable ESLint for most of this directory, and as a bonus it finds an issue with a duplicate field in the webpack configuration.

This is fixing formatting (prettier) and dot-notation issues.

Depends on D101317

Markus, if I adjust the patch to land without your changes from bug 1685948, would that be alright with you?

I think you'd just have to update D101304 to not change .eslintignore.

Flags: needinfo?(mstange.moz)

Yes, that would be great! I'll fold those .eslintignore changes into bug 1685948 then.

Flags: needinfo?(mstange.moz)
Attachment #9196347 - Attachment description: Bug 1685986 - Enable ESLint on gfx/wr/debugger/ where possible. r?mstange! → Bug 1685986 - Prepare to enable ESLint on gfx/wr/debugger/ where possible. r?mstange!
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a14bf5faa47 Automatically fix ESLint issues in gfx/wr/debugger. r=mstange https://hg.mozilla.org/integration/autoland/rev/45a5b517cd38 Prepare to enable ESLint on gfx/wr/debugger/ where possible. r=mstange
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: