1685991 - Add a Nightly Experiment option to search during IME composition

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Marco Bonardo [:mak]]

See bug 1673971, for now we can't easily detect whether we should search during IME or not, but we know that some users prefer that, and that when IME doesn't open a picker, the experience may be better.
To spread awareness of this pref, for now we can add a Nightly Experiment checkbox for it.

Comment 1

[Amy Churchwell [:amy]]

Hi Mak! Finally able to get to this.
In Features.toml I am not sure what the preference value should be for this new option. I saw https://hg.mozilla.org/integration/autoland/rev/7792ae96b5bb and am thinking it should be something imeCompositionClosesPanel?

Comment 2

[Harry Twyford]

It's browser.urlbar.imeCompositionClosesPanel. It's added here in firefox.js. That file lists most of the prefs available in Firefox.

Comment 3

[Amy Churchwell [:amy]]

Attachment: Bug 1685991 - Change default value of IME composition pref and add it to Nightly Experiments. r?harry

Comment 4

[Harry Twyford]

The scope of this bug now entails a bunch of changes to a pref, its tests, and a pref migration, so I'm bumping the points.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0bc10e33507
Change default value of IME composition pref and add it to Nightly Experiments. r=harry,fluent-reviewers,preferences-reviewers,Gijs,flod

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c0bc10e33507

Comment 7

[Magnus Melin [:mkmelin]]

The comment talking about the default value being "true" is now wrong. https://hg.mozilla.org/mozilla-central/rev/c0bc10e33507#l1.14

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84c563c1aa29
add "browser.urlbar.keepPanelOpenDuringImeComposition" pref to Thunderbird, to avoid test failures. rs=bustage-fix

Comment 9

[Amy Churchwell [:amy]]

Attachment: Bug 1685991 - Follow up - Update comment with correct value. r?harry

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79424a908a26
Follow up - Update comment with correct value. r=harry

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/79424a908a26