Closed Bug 1686195 Opened 4 years ago Closed 3 years ago

Remove code for submitting object elements

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: annevk, Unassigned)

References

Details

Now that plugins are obsolete, this code should never be able to run.

See https://github.com/whatwg/html/pull/6281. No tests as I'm not sure how web-platform-tests can test this.

this code should never be able to run.

Not seeing what "this code" means here, did you intend to attach something? 👀

Flags: needinfo?(annevk)

I did not, but https://searchfox.org/mozilla-central/source/dom/html/HTMLObjectElement.cpp#229-272 is part of it. I haven't looked into how that is called, but that might some tweaks as well. In the specification, form validation could be slightly simplified as well.

Flags: needinfo?(annevk)
Severity: -- → S3

I suspect this has been fixed at some point. HTMLObjectElement.h now has:

NS_IMETHOD SubmitNamesValues(FormData* aFormData) override { return NS_OK; }

(And HTMLObjectElement.cpp doesn't mention it at all anymore.)

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.