1686310 - Remove ReflowInput::mFrameType

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Mats Palmgren (inactive)]

ReflowInput::mFrameType is initialized using a few different sources: the frame's class, its display style value, and some of its IsFrameOfType() bits. This makes it hard to reason about code that uses it. Arguably, it's also setup wrong in some cases and one value (NS_CSS_FRAME_TYPE_FLOATING) isn't used at all.

Fortunately, it's not used very much so it's easy to surface the underlying conditions directly where they are used.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 1 - Remove NS_CSS_FRAME_TYPE_FLOATING. r=#layout

Comment 2

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 2 - Replace NS_FRAME_IS_REPLACED* with a bit that caches the corresponding IsFrameOfType result. r=#layout

Depends on D101548

Comment 3

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 3 - Replace NS_CSS_FRAME_TYPE_INTERNAL_TABLE with checks of the actual frame class, which is more correct. r=#layout

Depends on D101549

Comment 4

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 4 - Remove NS_CSS_FRAME_TYPE_ABSOLUTE. r=#layout

Depends on D101550

Comment 5

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 5 - Remove NS_CSS_FRAME_TYPE_BLOCK. r=#layout

Depends on D101551

Comment 6

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 6 - Remove NS_CSS_FRAME_TYPE_INLINE. r=#layout

Depends on D101552

Comment 7

[Mats Palmgren (inactive)]

Attachment: Bug 1686310 part 7 - Remove ReflowInput::mFrameType and associated code, which is now dead code. r=#layout

Depends on D101553

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c5254bea75a
part 1 - Remove NS_CSS_FRAME_TYPE_FLOATING. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d29ddd193684
part 2 - Replace NS_FRAME_IS_REPLACED* with a bit that caches the corresponding IsFrameOfType result. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ad097b5793e8
part 3 - Replace NS_CSS_FRAME_TYPE_INTERNAL_TABLE with checks of the actual frame class, which is more correct. r=emilio
https://hg.mozilla.org/integration/autoland/rev/5fb94fe99844
part 4 - Remove NS_CSS_FRAME_TYPE_ABSOLUTE. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b06ec5eca611
part 5 - Remove NS_CSS_FRAME_TYPE_BLOCK. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c4e1adb07c92
part 6 - Remove NS_CSS_FRAME_TYPE_INLINE. r=emilio
https://hg.mozilla.org/integration/autoland/rev/429a4d022ade
part 7 - Remove ReflowInput::mFrameType and associated code, which is now dead code. r=emilio

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7c5254bea75a
https://hg.mozilla.org/mozilla-central/rev/d29ddd193684
https://hg.mozilla.org/mozilla-central/rev/ad097b5793e8
https://hg.mozilla.org/mozilla-central/rev/5fb94fe99844
https://hg.mozilla.org/mozilla-central/rev/b06ec5eca611
https://hg.mozilla.org/mozilla-central/rev/c4e1adb07c92
https://hg.mozilla.org/mozilla-central/rev/429a4d022ade