Closed Bug 1686406 Opened 2 years ago Closed 2 years ago

remove Refcounted<PeerIdentity>

Categories

(Core :: WebRTC: Audio/Video, task, P2)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(5 files)

No description provided.

I expect BeginReading() happened to return the same string due to the storage
format, but using get() clarifies that this will provide what is required.

This will make a future diff to merge GetUserMediaStreamRunnable into
GetUserMediaTask more readable.

Depends on D101564

This also clarifies the safety of non-thread-safe PeerIdentity reference
counting.

There is a potential change in behavior because ~GetUserMediaStreamRunnable
rejected with AbortError, but ~GetUserMediaTask rejects with NotAllowedError.

Depends on D101565

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:karlt, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(karlt)
Severity: -- → S3
Priority: -- → P2
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f166c5e0c430
use API for nul-terminated string for call id r=jib
https://hg.mozilla.org/integration/autoland/rev/bbeb977d0676
update GetUserMediaStreamRunnable doc for promise API r=jib
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a2faa247faa
move GetUserMediaStreamRunnable doc and Run() definition r=jib
https://hg.mozilla.org/integration/autoland/rev/3bb760ae43e5
merge GetUserMediaStreamRunnable into GetUserMediaTask r=jib
https://hg.mozilla.org/integration/autoland/rev/f10fc402aba9
avoid Refcounted<PeerIdentity> to add Gecko thread-safety assertions r=pehrsons
Flags: needinfo?(karlt)
You need to log in before you can comment on or make changes to this bug.