1686406 - remove Refcounted<PeerIdentity>

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P2)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1686406 use API for nul-terminated string for call id r?jib

I expect BeginReading() happened to return the same string due to the storage
format, but using get() clarifies that this will provide what is required.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1686406 update GetUserMediaStreamRunnable doc for promise API r?jib

https://hg.mozilla.org/mozilla-central/rev/46c936ce7efed56027d7770690f94ee31f415d7a#l3.166

Depends on D101563

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1686406 move GetUserMediaStreamRunnable doc and Run() definition r?jib

This will make a future diff to merge GetUserMediaStreamRunnable into
GetUserMediaTask more readable.

Depends on D101564

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1686406 merge GetUserMediaStreamRunnable into GetUserMediaTask r?jib

This also clarifies the safety of non-thread-safe PeerIdentity reference
counting.

There is a potential change in behavior because ~GetUserMediaStreamRunnable
rejected with AbortError, but ~GetUserMediaTask rejects with NotAllowedError.

Depends on D101565

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1686406 avoid Refcounted<PeerIdentity> to add Gecko thread-safety assertions r?pehrsons

Depends on D101566

Comment 6

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/jobs?repo=try&revision=5dbc9c1416bca0e0724f93c1121378deade4c4cc
https://treeherder.mozilla.org/jobs?repo=try&revision=0bf9713dddce47e557e5290f9dda88a97c2a9001

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:karlt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f166c5e0c430
use API for nul-terminated string for call id r=jib
https://hg.mozilla.org/integration/autoland/rev/bbeb977d0676
update GetUserMediaStreamRunnable doc for promise API r=jib

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f166c5e0c430
https://hg.mozilla.org/mozilla-central/rev/bbeb977d0676

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a2faa247faa
move GetUserMediaStreamRunnable doc and Run() definition r=jib
https://hg.mozilla.org/integration/autoland/rev/3bb760ae43e5
merge GetUserMediaStreamRunnable into GetUserMediaTask r=jib
https://hg.mozilla.org/integration/autoland/rev/f10fc402aba9
avoid Refcounted<PeerIdentity> to add Gecko thread-safety assertions r=pehrsons

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0a2faa247faa
https://hg.mozilla.org/mozilla-central/rev/3bb760ae43e5
https://hg.mozilla.org/mozilla-central/rev/f10fc402aba9