1686426 - Add a debug assertion to ensure all documents in a DocGroup have the same cross-origin-isolated state

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Tom Tung [:tt, :ttung]]

When the cross-origin-isolated state is true, we use Origin as a key for the DocGroup. When the cross-origin-isolated state is false, we use SiteOrigin as a key for the DocGroup.
https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/dom/base/DocGroup.cpp#141-142

It's possible to have the same keys for the same origin but different cross-origin-isolated states. For instance, the origin and site origin for https://example.com are the same.

I thought it's not a problem since while a document is loading with both COOP and COEP headers are set, we load it on the cross-origin-isolated process per origin. So that two loaded documents with different cross-origin-isolated states should sit on different processes.

However, after thinking about this again, we should probably have a debug assertion to ensure all documents in the same DocGroup have the same state.

Comment 1

[Anne (:annevk)]

(Can we rename SiteOrigin to just Site? It's quite distinct from an Origin and that name seems like it might cause confusion.)

Comment 2

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a6301be4e510886c2d00daf317f5c6205c66e0c

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1686426 - Add a debug assertion to ensure all documents in a DocGroup have the same cross-origin-isolated state;

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3ac5e8fe668
Add a debug assertion to ensure all documents in a DocGroup have the same cross-origin-isolated state; r=nika

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a3ac5e8fe668