1686483 - [wpt-sync] Sync PR 27153 - [GridNG] Small fix to gap resolution, and abspos container.

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27153 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27153
Details from upstream follow.

b'Ian Kilpatrick <[e-mail]>' wrote:

[GridNG] Small fix to gap resolution, and abspos container.

Previously we'd just use the intrinsic block-size to resolve gaps, and
abs-pos containing rects when we didn't know the block-size upfront.

This was slightly incorrect as there might be a min/max size constraint
growing or shrinking this final size.

This patch moves the call to ComputeBlockSizeForFragment into
PlaceItems. As a result of this there are a few small fixes:

1. When we have an indefinite available-size, we resolve the grid-gap
   against zero. (This was surprising to me grid-gutters-{010,011} was
   testing this).
2. Abspos "default" size is correctly calculated based on the final
   block-size (not intrinsic block-size).
3. Resolving gaps against the "resolved" available block-size (not the
   intrinsic block-size). This correctly respects border/padding as
   well.

Bug: 1045599
Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Kurt Catti-Schmidt \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#842748}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d39e2ebb420e11ebb2a2358b9be45a14aaf18649

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

PASS: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d2d5479a4ee
[wpt PR 27153] - [GridNG] Small fix to gap resolution, and abspos container., a=testonly

Comment 4

[James Graham [:jgraham]]

Attachment: Bug 1686483 [wpt PR 27153] - [GridNG] Small fix to gap resolution, and abspos container., a=testonly

Automatic update from web-platform-tests
[GridNG] Small fix to gap resolution, and abspos container.

Previously we'd just use the intrinsic block-size to resolve gaps, and
abs-pos containing rects when we didn't know the block-size upfront.

This was slightly incorrect as there might be a min/max size constraint
growing or shrinking this final size.

This patch moves the call to ComputeBlockSizeForFragment into
PlaceItems. As a result of this there are a few small fixes:

1. When we have an indefinite available-size, we resolve the grid-gap
   against zero. (This was surprising to me grid-gutters-{010,011} was
   testing this).
2. Abspos "default" size is correctly calculated based on the final
   block-size (not intrinsic block-size).
3. Resolving gaps against the "resolved" available block-size (not the
   intrinsic block-size). This correctly respects border/padding as
   well.

Bug: 1045599
Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032
Commit-Queue: Ian Kilpatrick <[e-mail]>
Reviewed-by: Kurt Catti-Schmidt <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#842748}

--

wpt-commits: 7021d50a11fa620c3beac449ef044590d9e0fd1d
wpt-pr: 27153

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc51f913bad4
[wpt PR 27153] - [GridNG] Small fix to gap resolution, and abspos container., a=testonly

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fc51f913bad4