1686538 - [wpt-sync] Sync PR 27147 - WPT updates for highlight painting order (css-pseudo)

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 27147 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27147
Details from upstream follow.

b'Delan Azabani <[e-mail]>' wrote:

WPT updates for highlight painting order (css-pseudo)

This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
• two manual tests, checking the relative painting order of
::selection and ::{grammar,spelling}-error overlays
• added @contenteditable/@spellcheck/@lang to test element
• added Selection#removeAllRanges call to work around API change
• replaced the grammar test sentence with a more obvious example
• rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
• new reftest, checking relative painting order of text, original
shadows, ::selection background, and ::selection shadows
• based on <https://bucket.daz.cat/work/igalia/0/3.html>

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
• one manual test, one reftest, checking that text-shadow:none in
::selection suppresses all original shadows (even if multiple)
• dropped because they are no longer compliant (highlight overlays
have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f

Reviewed-on: https://chromium-review.googlesource.com/2624328
WPT-Export-Revision: 7a404aa6fd0f8688b1bf78b53916edd9424b1d5d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cd0144cdbc8b36282b324d02d126d236b9f4e1d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/highlight-painting-order.html: FAIL (Chrome: FAIL)
/css/css-pseudo/selection-overlay-and-grammar-001.html: FAIL (Chrome: FAIL)
/css/css-pseudo/selection-overlay-and-spelling-001.html: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/870ae590e2b1
[wpt PR 27147] - WPT updates for highlight painting order (css-pseudo), a=testonly
https://hg.mozilla.org/integration/autoland/rev/be4db9a1e3bb
[wpt PR 27147] - Update wpt metadata, a=testonly

Comment 4

[James Graham [:jgraham]]

Attachment: Bug 1686538 [wpt PR 27147] - WPT updates for highlight painting order (css-pseudo), a=testonly

Automatic update from web-platform-tests
WPT updates for highlight painting order (css-pseudo)

This patch updates four web platform tests involving CSS highlight
painting order, which should help us rework our highlight paint code
to comply with css-pseudo.

• css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html
• two manual tests, checking the relative painting order of
::selection and ::{grammar,spelling}-error overlays
• added @contenteditable/@spellcheck/@lang to test element
• added Selection#removeAllRanges call to work around API change
• replaced the grammar test sentence with a more obvious example
• rewrote most of the comments for clarity

• css/css-pseudo/highlight-painting-order.html
• new reftest, checking relative painting order of text, original
shadows, ::selection background, and ::selection shadows
• based on https://bucket.daz.cat/work/igalia/0/3.html

• css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html
• one manual test, one reftest, checking that text-shadow:none in
::selection suppresses all original shadows (even if multiple)
• dropped because they are no longer compliant (highlight overlays
have their own shadows, independent of the content’s shadows)

Bug: 1147859
Change-Id: I29bab589e3924778d555d96537d010dc33ed003f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328
Commit-Queue: Delan Azabani <[e-mail]>
Reviewed-by: Rune Lillesveen <[e-mail]>
Reviewed-by: Yoshifumi Inoue <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#843482}

--

wpt-commits: 9d3e9615ee9db69e2feadd8a840431749c80df87
wpt-pr: 27147

Comment 5

[James Graham [:jgraham]]

Attachment: Bug 1686538 [wpt PR 27147] - Update wpt metadata, a=testonly

wpt-pr: 27147
wpt-type: metadata

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16561449c9d9
[wpt PR 27147] - WPT updates for highlight painting order (css-pseudo), a=testonly
https://hg.mozilla.org/integration/autoland/rev/0b12d88086af
[wpt PR 27147] - Update wpt metadata, a=testonly

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/16561449c9d9
https://hg.mozilla.org/mozilla-central/rev/0b12d88086af