1686570 - Add "Part of this page crashed" tooltip when user mouses over a crashed subframe

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Chris Peterson [:cpeterson]]

A crashed subframe will be replaced with the red "sad tab" icon after the page shows the user the subframe crash notification bar. The UX team suggests we add a tooltip saying "Part of this page crashed" when user mouses over a crashed subframe.

The "Part of this page crashed" string should match the string used in the subframe crash notification bar (browser.ftl string crashed-subframe-message from bug 1644911's D97346 patch).

Comment 1

[Chris Peterson [:cpeterson]]

Nice to have before Fission MVP. Someone just needs to add a title attribute to the "sad frame" placeholder element inside a crashed subframe.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 3

[Neha Kochar [:neha]]

Gabriele, who can work on this?

Comment 4

[Gabriele Svelto [:gsvelto]]

That's a front-end change, IIRC Mike Conley did most of the heavy lifting in that area (crashed tabs) but I think his queue is already full. Maybe someone else from his team?

Comment 5

[Neha Kochar [:neha]]

Blake, who from your team can do this in the frontend?

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Probably anyone… It doesn't sound too hard. 😉
You could ask Molly, Neil, or Gijs and see if they wanted to pick it up in their spare time.
(Or maybe Mike would like a break from investigating stuff, and would relish the chance to write a quick bit of code… 🙂)

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1686570 - Add a tooltip for crashed subframes. r?flod!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9981081ce5ca
Add a tooltip for crashed subframes. r=flod,fluent-reviewers

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9981081ce5ca

Comment 10

[Chris Peterson [:cpeterson]]

Verified fixed in Nightly 91.0a1 (2021-06-25).